Review main Abandoned

63966[BUGFIX] Apply maxlength check for passwords in ext:setup

Christian Eßl CR 0 V 0 Easy +11 −2 updated 11/04/21, 12:57

Commit message

The user settings form in ext:setup was missing the javascript-side
password length checks for passwords. Furthermore, the already existing
maxlength checks for the name and email fields were broken as well, as
the FormEngine was never initialized.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 1013

  1. Christian Eßl uploaded patch set 1 03/28/20, 12:06

  2. TYPO3com voted on patch set 1 V +1 03/28/20, 12:25 Completed build in 19m 04s on Sat, 28 Mar, 12:25 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1894

  3. Benni Mack commented on patch set 1 04/12/20, 12:16

    Looks like we could/should migrate to a full-blown FormEngine rendering to also use this for other logic?
  4. Christian Eßl commented on patch set 1 04/12/20, 13:07

    > Patch Set 1: > > Looks like we could/should migrate to a full-blown FormEngine rendering to also use this for other logic? This small patch restores the status quo, which at one time already worked. See related issue #79532. But I guess some refactorings done in the JavaScript parts broke those checks at some time in the past? Migrating ext:setup to a full-blown FormEngine rendering could help stabilize these parts, so it won't need to implement its own, inferior form rendering logic or produce similar bugs in the future... but IMO this is something for TYPO3 11 development.
  5. Oliver Hader commented on patch set 1 05/02/20, 12:26

    SetupModuleController.php:155 Unresolved

    Please let's try to avoid introducing new inline JavaScript code in v10... In case https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225 gets merged - initializations can be done there... any maybe expose USdateFormat to inline settings
  6. Benni Mack updated the commit message in patch set 2 05/25/20, 18:49

  7. Benni Mack voted on patch set 2 V +1 CR +1 05/25/20, 18:49

  8. TYPO3com voted on patch set 2 V +1 05/25/20, 20:32 Completed build in 1h 34m 21s on Mon, 25 May, 08:32 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3541

  9. Anja Leichsenring commented on patch set 2 05/31/20, 13:59

    ping. The patch requested by Oli has been merged, so this one here can get an update, please?
  10. Oli Bartsch uploaded patch set 3 09/04/20, 09:37

  11. TYPO3com voted on patch set 3 V +1 09/04/20, 09:48 Completed build in 10m 57s on Fri, 4 Sep, 09:48 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5223

  12. Oliver Hader commented on patch set 3 09/04/20, 13:11

    Is the length limit caused by limitations of HTML (W3C spec) or related to internal processing of those values?
  13. Benni Mack abandoned the change 11/04/21, 12:57

    I will abandon this change for now, due to lack of activity. can be restored again alter