Review 9.5 Abandoned

63967[BUGFIX] Catch InvalidRequestTokenException in AjaxRequestHandler

Christian Eßl CR 0 V 0 Easy +10 −3 updated 10/03/21, 14:51

Commit message

If a backend session runs out, the old AjaxRequestHandler fails to
handle this scenario and would throw an InvalidRequestTokenException.
In this case, return an empty response with status code 403 instead.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Christian Eßl uploaded patch set 1 03/28/20, 13:25

  2. TYPO3com voted on patch set 1 V +1 03/28/20, 13:36 Completed build in 11m 52s on Sat, 28 Mar, 01:36 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-375

  3. Jörg Bösche voted on patch set 1 CR +1 08/28/20, 09:38

  4. Frank Nägler commented on patch set 1 CR -1 11/22/20, 19:11

    AjaxRequestHandler.php:77 Unresolved

    I suggest to use 401 Unauthorized, it is more meaningful. 403 Forbidden is a response for a valid request on a resource without permissions to access.
  5. Benni Mack abandoned the change 10/03/21, 14:51

    This change is abandoned as there is no upcoming free-of-charge 9.5 release anymore.