Review main Merged

63968[TASK] Streamline BackendLayout API class

Claus Due CR +2 V +2 Easy +5 −11 updated 03/29/20, 11:54

Commit message

Followup with minor corrections for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918

* Relaxes method signature of getSelectedBackendLayout
  to restore compatibilty with third party XCLASS.
* Avoids parsing empty configuration strings (in use
  cases where configuration is passed to BackendLayout
  as array, not TS string).
* Uses DrawingConfiguration instance provided from
  BackendLayout instead of creating a new instance to
  override the one returned from BackendLayout.
* Fixes a method call with unused return value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Claus Due uploaded patch set 1 03/28/20, 13:51

  2. TYPO3com voted on patch set 1 V -1 03/28/20, 13:52 Completed build in 29s on Sat, 28 Mar, 01:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1895

  3. Claus Due uploaded patch set 2 03/28/20, 13:53

  4. TYPO3com voted on patch set 2 V +1 03/28/20, 14:05 Completed build in 11m 50s on Sat, 28 Mar, 02:05 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1896

  5. Georg Ringer commented on patch set 2 03/28/20, 14:39

    remote the followup, we don'T really do that IMO anymore, every patch is a followup of some other patch ;)
  6. Claus Due updated the commit message in patch set 3 03/28/20, 15:02

  7. Claus Due commented on patch set 3 03/28/20, 15:03

    Reply

    Done
  8. TYPO3com voted on patch set 3 V +1 03/28/20, 15:21 Completed build in 18m 28s on Sat, 28 Mar, 03:21 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1898

  9. Benni Mack voted on patch set 3 V +2 CR +2 03/29/20, 11:54

  10. Benni Mack merged patch set 4 03/29/20, 11:54