Review main Merged

63969[TASK] Make attributes in AssetCollector optional

Christian Eßl CR +2 V +2 Easy +4 −4 updated 03/28/20, 19:58

Commit message

The AssetCollector does not necessarily need a filled array with
attributes for adding javascript or stylesheets. Make the $attributes
argument optional and default to an empty array.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Jonas Eberle +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Eßl uploaded patch set 1 03/28/20, 14:42

  2. TYPO3com voted on patch set 1 V +1 03/28/20, 14:55 Completed build in 13m 02s on Sat, 28 Mar, 02:55 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1897

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/28/20, 16:56

  4. Jonas Eberle voted on patch set 1 V +1 CR +1 03/28/20, 17:09

  5. Frank Nägler voted on patch set 1 V +2 CR +2 03/28/20, 19:58

  6. Frank Nägler merged patch set 2 03/28/20, 19:58