Review main Merged

63970[TASK] Add documentation for AssetCollector

Jonas Eberle CR +2 V +2 Normal +61 −0 updated 03/28/20, 22:06

Commit message

This adds phpdoc for the public AssetCollector::add...() functions and
notes for users migrating from PageRenderer::add...().

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Jonas Eberle uploaded patch set 1 03/28/20, 19:48

  2. TYPO3com voted on patch set 1 V -1 03/28/20, 19:59 Completed build in 10m 39s on Sat, 28 Mar, 07:59 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1902

  3. Jonas Eberle uploaded patch set 2 03/28/20, 20:10

  4. TYPO3com voted on patch set 2 V +1 03/28/20, 20:37 Completed build in 18m 25s on Sat, 28 Mar, 08:37 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1906

  5. Jonas Eberle commented on patch set 2 03/28/20, 21:46

    I spotted an error (addInlineJavaScript). Will push new patchset.
  6. Jonas Eberle uploaded patch set 3 03/28/20, 21:48

  7. TYPO3com voted on patch set 3 V +1 03/28/20, 22:00 Completed build in 11m 38s on Sat, 28 Mar, 10:00 PM Test Summary: 73048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1916

  8. Frank Nägler voted on patch set 3 V +1 CR +1 03/28/20, 22:02

  9. Frank Nägler voted on patch set 3 V +2 CR +2 03/28/20, 22:05

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 03/28/20, 22:05

  11. Frank Nägler merged patch set 4 03/28/20, 22:06