Review main Merged

63971[BUGFIX] Fix visibility of translate button in old PageLayoutView

Christian Eßl CR +2 V +2 Easy +1 −0 updated 03/29/20, 07:14

Commit message

The old, non-fluidbased PageLayoutView was missing the translate button
for editors, even when they had the right permissions to edit content,
because the property $pageinfo wasn't initialized early enough before
the permission check.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Eßl uploaded patch set 1 03/28/20, 20:02

  2. TYPO3com voted on patch set 1 V +1 03/28/20, 20:29 Completed build in 23m 22s on Sat, 28 Mar, 08:29 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1905

  3. Frank Nägler voted on patch set 1 V +1 CR +1 03/28/20, 21:11

  4. Georg Ringer voted on patch set 1 V +2 CR +2 03/29/20, 07:14

  5. Georg Ringer merged patch set 2 03/29/20, 07:14