63974Revert "[BUGFIX] Automatically use JsonView for json format"
Commit message
Review
-
Code review CR +2 Done
- Alexander Schnitzler +2
- Daniel Goerz +1
- Andreas Kienast +1
- Christian Eßl +1
-
Verified V +2 Done
- Alexander Schnitzler +2
- Daniel Goerz +1
- Andreas Kienast +1
- Christian Eßl +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+4 −32
- typo3/sysext/extbase/Classes/Mvc/View/GenericViewResolver.phpdeleted+0 −54
- typo3/sysext/extbase/Classes/Mvc/View/ViewResolverInterface.phpdeleted+0 −15
- typo3/sysext/extbase/Configuration/Services.yaml+0 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Controller/TestController.php+0 −5
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+0 −47
Review log 78
-
Alexander Schnitzler uploaded patch set 1 03/30/20, 14:36
-
Alexander Schnitzler commented on patch set 1 03/30/20, 14:38
After this revert, I will reimplement this patch properly. The actual fix is a oneliner but still it's cleaner to revert and reimplement as the commit message of the original patch included false statements regarding the inner workings of Extbase. -
TYPO3com voted on patch set 1 V +1 03/30/20, 14:46 Completed build in 10m 26s on Mon, 30 Mar, 02:46 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1967
-
Alexander Schnitzler voted on patch set 1 V +2 CR +2 03/30/20, 15:01
-
Andreas Kienast voted on patch set 1 V +1 CR +1 03/30/20, 15:06
-
Christian Eßl voted on patch set 1 V +1 CR +1 03/30/20, 15:08
-
Daniel Goerz voted on patch set 1 V +1 CR +1 03/30/20, 15:11
-
Alexander Schnitzler merged patch set 2 03/30/20, 15:17