Review main Merged

63974Revert "[BUGFIX] Automatically use JsonView for json format"

Alexander Schnitzler CR +2 V +2 Normal +4 −156 updated 03/30/20, 15:17

Commit message

This reverts commit 9c0e151e311639fbc930ba36f767ec11dfef2bef.

The original patch followed the misconception that when using json as format query parameter, Extbase would automatically use the JsonView object. Instead, Extbase should only try to find a template file with a .json file type.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 78

  1. Alexander Schnitzler uploaded patch set 1 03/30/20, 14:36

  2. Alexander Schnitzler commented on patch set 1 03/30/20, 14:38

    After this revert, I will reimplement this patch properly. The actual fix is a oneliner but still it's cleaner to revert and reimplement as the commit message of the original patch included false statements regarding the inner workings of Extbase.
  3. TYPO3com voted on patch set 1 V +1 03/30/20, 14:46 Completed build in 10m 26s on Mon, 30 Mar, 02:46 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1967

  4. Alexander Schnitzler voted on patch set 1 V +2 CR +2 03/30/20, 15:01

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 03/30/20, 15:06

  6. Christian Eßl voted on patch set 1 V +1 CR +1 03/30/20, 15:08

  7. Daniel Goerz voted on patch set 1 V +1 CR +1 03/30/20, 15:11

  8. Alexander Schnitzler merged patch set 2 03/30/20, 15:17