Review 9.5 Merged

63976[BUGFIX] Provide inlineParentUid in FormInlineAjaxController

Benni Mack CR +2 V +2 Easy +2 −1 updated 03/31/20, 11:43

Commit message

By expanding an inline record the AJAX request calls the `detailAction`
in `FormInlineAjaxController`. The parent data array created in this
function does not contain the parent record's uid nor its database row.

In order to ensure that the uid is not NULL, in any FormDataProvider,
the uid is now added to the parent data array. This value is then used
as fallback in case there is no database row given in the `compileChild`
function which calls the FormDataProviders.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 03/31/20, 09:41

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/31/20, 10:04 Completed build in 20m 16s on Tue, 31 Mar, 10:04 AM Test Summary: 74097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-390

  3. TYPO3com voted on patch set 1 V +1 03/31/20, 11:09 Completed build in 1h 44m 54s on Tue, 31 Mar, 11:09 AM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-390

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/31/20, 11:43

  5. Benni Mack merged patch set 2 03/31/20, 11:43