Review 9.5 Merged

63982[BUGFIX] Always show download icons in language pack module

Benni Mack CR +2 V +2 Easy +16 −22 updated 04/04/20, 20:47

Commit message

The Install Tool module "Manage Language Packs" is improved by the
following changes:

* If all language packs of an extension are available, the download icon
is still shown to make downloads of a single language pack per extension
possible.
* The icon itself changed from refresh to download as there is no
refresh possible. There is no lock on a specific date or version to
reload language packs. Every download can contain new or changed
translations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 610

  1. Benni Mack commented on patch set 1 04/03/20, 06:59

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/LanguagePacks.ts * typo3/sysext/install/Resources/Private/Templates/Maintenance/LanguagePacks.html * typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/LanguagePacks.js
  2. TYPO3com voted on patch set 1 V -1 04/03/20, 07:13 Completed build in 13m 49s on Fri, 3 Apr, 07:13 AM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-412

  3. TYPO3com voted on patch set 1 V +1 04/03/20, 19:58 Completed build in 18m 34s on Fri, 3 Apr, 07:58 PM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-416

  4. Georg Ringer voted on patch set 1 V +1 CR +1 04/04/20, 11:36

  5. Oli Bartsch uploaded patch set 2 04/04/20, 11:58

  6. Oli Bartsch updated the commit message in patch set 3 04/04/20, 12:08

  7. TYPO3com voted on patch set 2 V +1 04/04/20, 12:10 Completed build in 11m 53s on Sat, 4 Apr, 12:10 PM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-418

  8. TYPO3com voted on patch set 3 V +1 04/04/20, 12:20 Completed build in 11m 46s on Sat, 4 Apr, 12:20 PM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-419

  9. Benni Mack commented on patch set 3 V +2 CR +2 04/04/20, 20:47

    This change is ready for review.
  10. Benni Mack merged patch set 4 04/04/20, 20:47