Review 9.5 Merged

63985[BUGFIX] Preserve selection ranges in RteLinkBrowser

Josef Glatz CR +2 V +2 Easy +6 −1 updated 04/05/20, 10:24

Commit message

When the RteLinkBrowser is opened, any active ranges are now backed up
and reused later when an element gets linked. This fixes clashes with
the browser's internal search feature that overrides the `Selection`
object.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Josef Glatz commented on patch set 1 04/05/20, 06:52

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/rte_ckeditor/Resources/Public/TypeScript/RteLinkBrowser.ts * typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/RteLinkBrowser.js
  2. Andreas Kienast uploaded patch set 2 04/05/20, 06:54

  3. Josef Glatz commented on patch set 2 04/05/20, 06:55

    This change is ready for review.
  4. Andreas Kienast commented on patch set 3 04/05/20, 06:59

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 1 V +1 04/05/20, 07:21 Completed build in 28m 05s on Sun, 5 Apr, 07:21 AM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-423

  6. TYPO3com voted on patch set 2 V +1 04/05/20, 07:27 Completed build in 14m 22s on Sun, 5 Apr, 07:27 AM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-424

  7. Josef Glatz voted on patch set 3 CR -1 04/05/20, 07:28

  8. TYPO3com voted on patch set 3 V +1 04/05/20, 07:32 Completed build in 19m 24s on Sun, 5 Apr, 07:32 AM Test Summary: 74664 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-425

  9. Andreas Kienast uploaded patch set 4 04/05/20, 07:40

  10. Josef Glatz voted on patch set 4 V +1 CR +1 04/05/20, 07:47

  11. TYPO3com voted on patch set 4 V +1 04/05/20, 07:54 Completed build in 13m 33s on Sun, 5 Apr, 07:54 AM Test Summary: 74694 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-426

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 04/05/20, 10:24

  13. Andreas Kienast merged patch set 5 04/05/20, 10:24