Review 9.5 Merged

63990[TASK] Restructure and fine-tune builds

Andreas Kienast CR +2 V +2 Hard +110 −391 updated 04/08/20, 05:35

Commit message

This patch updates the Docker configuration to use mssql 2019 as mssql
2017 images don't get updates anymore.

Additionally to the mssql update, the shuffled chunking to 50 jobs is
reverted as it didn't bring any benefit but even more hassle as the
stages failed earlier and more often. Instead, the jobs are now grouped
by PHP version which allows smaller chunks and reduced the probability to
clog the build queue.

To workaround errors thrown by Gerrit on heavy load, the cherry-pick
command is now executed up to five times, with a short sleep between each
execution.

Last but not least we check whether there is actually a dangling Docker
container instead of hard killing non-existent containers which pollutes
our log.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 57

  1. Andreas Kienast commented on patch set 1 04/07/20, 06:00

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/bamboo/src/main/java/core/NightlySpec.java
  2. Andreas Kienast uploaded patch set 2 04/07/20, 06:04

  3. TYPO3com voted on patch set 1 V +1 04/07/20, 06:14 Completed build in 13m 23s on Tue, 7 Apr, 06:14 AM Test Summary: 74694 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-440

  4. TYPO3com voted on patch set 2 V +1 04/07/20, 06:20 Completed build in 14m 06s on Tue, 7 Apr, 06:20 AM Test Summary: 74694 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-441

  5. Andreas Kienast commented on patch set 2 04/08/20, 05:35

    This change is ready for review.
  6. Andreas Kienast voted on patch set 2 V +2 CR +2 04/08/20, 05:35

  7. Andreas Kienast merged patch set 3 04/08/20, 05:35