Review main Merged

63993[BUGFIX] Fix TypeError in AssetCollector if identifier is numeric

Jonas Eberle CR +2 V +2 Easy +2 −2 updated 03/28/20, 22:01

Commit message

Although registered as "string" argument in the ViewHelper, an incoming
string that is_numeric() is cast to an integer, leading to a TypeError.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 58

  1. Jonas Eberle uploaded patch set 1 03/28/20, 20:19

  2. TYPO3com voted on patch set 1 V -1 03/28/20, 20:20 Completed build in 48s on Sat, 28 Mar, 08:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1908

  3. Jonas Eberle uploaded patch set 2 03/28/20, 20:22

  4. TYPO3com voted on patch set 2 V -1 03/28/20, 20:58 Completed build in 23m 23s on Sat, 28 Mar, 08:58 PM Test Summary: 8 of 73225 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1911

  5. TYPO3com voted on patch set 2 V +1 03/28/20, 21:22 Completed build in 12m 24s on Sat, 28 Mar, 09:22 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1914

  6. Frank Nägler voted on patch set 2 V +1 CR +1 03/28/20, 22:01

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 03/28/20, 22:01

  8. Andreas Kienast merged patch set 3 03/28/20, 22:01