Review main Abandoned

63994[BUGFIX] Fix TypeError in AssetCollector if identifier is numeric

Jonas Eberle CR 0 V 0 Easy +2 −2 updated 03/28/20, 20:21

Commit message

Although registered as "string" argument in the ViewHelper, an incoming
string that is_numeric() is cast to an integer, leading to a TypeError.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 23

  1. Jonas Eberle uploaded patch set 1 03/28/20, 20:19

  2. TYPO3com voted on patch set 1 V -1 03/28/20, 20:20 Completed build in 42s on Sat, 28 Mar, 08:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1909

  3. Jonas Eberle abandoned the change 03/28/20, 20:21

    2 reviews were erroneously opened