Review main Abandoned

63995[BUGFIX] Show content with language="All" in fluidbased PageLayoutView

Christian Eßl CR 0 V 0 Easy +7 −2 updated 04/22/20, 10:45

Commit message

The new, fluidbased PageLayoutView didn't show content elements with
sys_language_uid="-1" in both the "columns" and "languages" mode.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1213

  1. Christian Eßl uploaded patch set 1 03/28/20, 20:37

  2. TYPO3com voted on patch set 1 V +1 03/28/20, 21:04 Completed build in 15m 25s on Sat, 28 Mar, 09:04 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1912

  3. Riccardo De Contardi commented on patch set 1 V +1 03/28/20, 21:06

    before: content with language -1 not visible on page module after: content visible; in language mode, the same content is replicated (and editable) for every language columnn.
  4. Benni Mack commented on patch set 1 03/30/20, 07:46

    ContentFetcher.php:91

    this might become a problem I guess. IMHO the whole logic here is completely broken. It should behave as in frontend / overlay mode and in DataHandler. "0" and "-1" are treated the exactly the same way (within one database query!), and the others can be loaded separately. Otherwise we have a problem with sorting in general - and mostly because it is different to all the other places. I already suggested that ContentFetcher would be a really good start for doing functional tests.
  5. Oliver Hader commented on patch set 1 03/30/20, 08:55

    ContentFetcher.php:91 Reply Unresolved

    Actually it should use something like PageRepository instead... I don't see a reason to duplicate workspaces and especially language handling logic in a new spot.

    ContentFetcher.php:92 Unresolved

    In general I'd suggest to avoid references to native types as much as possible. Chances are high that this might cause undesired side-effects (probably should be addressed with this fix as well)...
  6. Oliver Hader commented on patch set 1 CR -1 03/30/20, 08:56

    It has some code-smell... and without actually having tests, we are going to repeat the story of breaking language/workspaces overlay handling again and again...
  7. Oliver Hader commented on patch set 1 03/30/20, 08:57

    > Patch Set 1: Code-Review-1 > > It has some code-smell... and without actually having tests, we are going to repeat the story of breaking language/workspaces overlay handling again and again... ... that's not related on this very patch, but basically the already existing implementation in the new `ContentFetcher`
  8. Claus Due commented on patch set 1 03/30/20, 09:01

    I had a similar solution sketched locally and there seems to be some related issues, such as the ability to drag and drop -1 language content in other languages than default, which causes side effects such as moving the dragged -1 language content to whichever language the dropzone had. We may have to disable drag and drop for these elements when viewed in non-default langages. I was looking at a solution that analyses the record during the mapping that ContentFetcher does, placing any -1 language content into each of the shown languages' columns, combined with additional checks for whether to allow things like drag and drop.
  9. Claus Due commented on patch set 1 03/30/20, 09:03

    I should also note that the logic in ContentFetcher is copied from PageLayoutView and behaves the same way. If we need to reproduce the exact behavior of PageLayoutView I'm pretty sure that has to happen through processing at render time instead of query time.
  10. Claus Due commented on patch set 1 03/30/20, 09:27

    Hmm, PageLayoutView actually allows a -1 language content to be moved around, and when dropping the content record the language changes to whichever language you are viewing. It also does not render the language element in other languages in "Languages" view mode; only in "Columns" view does it render such content records. Q1: should we change this "allow drag and drop" behavior since it is a source of inconsistency? Q2: should we render -1 language content in other columns than "default language" when module is in "Languages" mode?
  11. Claus Due commented on patch set 1 04/20/20, 10:46

    A fix for this issue was merged as part of https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002.
  12. Christian Eßl commented on patch set 1 04/22/20, 10:45

    Cool, then I'll abandon this patch here. :)
  13. Christian Eßl abandoned the change 04/22/20, 10:45