Review main Merged

63996[TASK] Change boolean HTML attributes in AssetCollector ViewHelpers

Jonas Eberle CR +2 V +2 Easy +18 −4 updated 03/28/20, 22:04

Commit message

As boolean HTML attributes shall either have a value equal to the
attribute name (e.g. async="async") or have no value at all (only allowed
in HTML5), the ViewHelper reflects that now.

All boolean HTML attributes on <script> (async, defer, nomodule) and
<link> (disabled) have been changed to Fluid "bool" ("0" and "false" is
false, rest is true).

This allows using the ViewHelpers with e.g. async="1" which before would
have output <script async="1">. Now it is registered as async="async"
with AssetCollector.

References:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Jonas Eberle uploaded patch set 1 03/28/20, 20:57

  2. TYPO3com voted on patch set 1 V +1 03/28/20, 21:09 Completed build in 12m 16s on Sat, 28 Mar, 09:09 PM Test Summary: 73049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1913

  3. Frank Nägler voted on patch set 1 V +1 CR +1 03/28/20, 21:51

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 03/28/20, 22:04

  5. Andreas Kienast merged patch set 2 03/28/20, 22:04