64003[BUGFIX] Always show download icons in language pack module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2125
-
Georg Ringer uploaded patch set 1 03/30/20, 09:13
-
Georg Ringer commented on patch set 1 03/30/20, 09:13
This change is ready for review. -
Josef Glatz voted on patch set 1 V +1 CR +1 03/30/20, 09:29
-
TYPO3com voted on patch set 1 V +1 03/30/20, 09:30 Completed build in 16m 29s on Mon, 30 Mar, 09:30 AM Test Summary: 73056 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1946
-
Josef Glatz commented on patch set 1 03/30/20, 09:33
Add also a screenshot of patchset-1 at https://forge.typo3.org/issues/86535#note-6 -
Jonas Eberle commented on patch set 1 CR -1 03/30/20, 09:34
The tooltip for system extensions says "Last download at null. Click to renew". -
Jonas Eberle voted on patch set 1 V -1 CR 0 03/30/20, 09:34
-
Jonas Eberle commented on patch set 1 03/30/20, 10:02
The "Last download at null" does not only affect sysexts. It is shown for all packs that were already downloaded. The tooltip is OK for "No language pack available for ... when tried at ..." and "Language pack not downloaded" -
Georg Ringer uploaded patch set 2 03/30/20, 10:59
-
Jonas Eberle commented on patch set 2 V -1 03/30/20, 11:12
It shows "Language pack not downloaded" for packs that have been downloaded.LanguagePacks.ts:470pack.lastUpdate seems to be null even for downloaded packages -
TYPO3com voted on patch set 2 V +1 03/30/20, 11:15 Completed build in 15m 22s on Mon, 30 Mar, 11:15 AM Test Summary: 73056 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1954
-
Georg Ringer commented on patch set 2 03/30/20, 11:21
LanguagePacks.ts:470Replycan you debug that? however I didn't change anything regarding storing the lastUpdate -
Jonas Eberle commented on patch set 2 03/30/20, 11:27
LanguagePacks.ts:470Reply Unresolvedpack.lastUpdate was never used before for the case pack.exists===true. It has been null before, too. The problem is probably somewhere in the controller. I suggest we just remove that information from the tooltip for installed packs and be done with it... -
Georg Ringer uploaded patch set 3 03/30/20, 12:10
-
TYPO3com voted on patch set 3 V -1 03/30/20, 12:22 Completed build in 11m 53s on Mon, 30 Mar, 12:22 PM Test Summary: 2 of 73542 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1959
-
Josef Glatz voted on patch set 3 V +1 CR +1 03/30/20, 15:00
-
Josef Glatz commented on patch set 3 03/30/20, 15:20
Patch Set 3: Looks good to me ------------------------------- Don't get the problem which Jonas reports. You can contact me via slack PM if you want :-) What is actually possible with the patch set 3: * I can push the button to update all language packages for all extensions with one click * I can push the button to update a single language pack of an extension no matter if the language pack exists locally since the TYPO3 instance doesn't know if there are updates on the translation-/crowdin-serverside. * The download button looks more intuitive, since there are no checks if there is an update What is not really part of this issue, is the fact, that if you update a language pack where no language pack is available the message is green – this is another issue IMO. -
Jonas Eberle commented on patch set 3 CR -1 03/30/20, 15:30
LanguagePacks.ts:472UnresolvedThe condition is mixed up. I'll push a new patchset. -
Jonas Eberle uploaded patch set 4 03/30/20, 15:37
-
TYPO3com voted on patch set 4 V +1 03/30/20, 15:48 Completed build in 11m 12s on Mon, 30 Mar, 03:48 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1971
-
Benni Mack voted on patch set 4 V +1 CR +1 03/30/20, 19:18
-
Josef Glatz voted on patch set 4 V +1 CR +1 03/31/20, 04:45
-
Oli Bartsch voted on patch set 4 V +1 CR +1 04/03/20, 06:52
-
Benni Mack voted on patch set 4 V +2 CR +2 04/03/20, 06:59
-
Benni Mack merged patch set 5 04/03/20, 06:59