Review main Merged

64005[BUGFIX] Cast values passed to htmlspecialchars to string in ArrayBrowser

Christian Eßl CR +2 V +2 Easy +2 −2 updated 04/03/20, 19:26

Commit message

The $key in ArrayBrowser can sometimes be numeric. Cast the $key to
string before handing it to htmlspecialchars() to prevent type errors.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Georg Tiefenbrunn +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Georg Tiefenbrunn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1822

  1. Christian Eßl uploaded patch set 1 03/30/20, 11:24

  2. TYPO3com voted on patch set 1 V -1 03/30/20, 11:40 Completed build in 14m 56s on Mon, 30 Mar, 11:40 AM Test Summary: 3 of 73540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1956

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/30/20, 11:49

  4. TYPO3com commented on patch set 1 03/30/20, 12:12 Completed build in 1h 02m 01s on Mon, 30 Mar, 12:12 PM Test Summary: 3 of 73540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1956

  5. Oliver Klee commented on patch set 1 03/30/20, 12:14

    Is 9.5 affected as well?
  6. Christian Eßl commented on patch set 1 03/30/20, 12:26

    Reply

    No, reason for the error is a recent cleanup in master, that introduced strict type checks for the class.
  7. Oliver Klee voted on patch set 1 CR +1 03/30/20, 12:37

  8. Julian Mair voted on patch set 1 CR +1 03/30/20, 17:49

  9. Georg Tiefenbrunn commented on patch set 1 CR -1 04/02/20, 11:27

    $value could also be numeric or boolean.

    ArrayBrowser.php:117

    Cast `$value` to string (could be `int` or `bool`)
  10. Alexander Schnitzler commented on patch set 1 04/02/20, 11:29

    ArrayBrowser.php:117 Reply

    Yes, what about this place? I ran into the error with this part not being a string.
  11. Andreas Kienast commented on patch set 1 04/02/20, 11:40

    ArrayBrowser.php:117 Reply

    I guess it's about $value, not about $key
  12. Alexander Schnitzler commented on patch set 1 04/02/20, 18:58

    ArrayBrowser.php:117 Reply Unresolved

    Got it. But let's not forget about the value.
  13. Andreas Kienast commented on patch set 2 04/03/20, 14:36

    Published edit on patch set 1.
  14. Oliver Klee voted on patch set 2 CR +1 04/03/20, 14:41

  15. TYPO3com voted on patch set 2 V +1 04/03/20, 14:48 Completed build in 12m 05s on Fri, 3 Apr, 02:48 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2127

  16. Georg Tiefenbrunn commented on patch set 2 V +1 CR +1 04/03/20, 14:51

    Consider altering the commit message: [BUGFIX] Cast values passed to htmlspecialchars to string in ArrayBrowser
  17. Christian Eßl updated the commit message in patch set 3 04/03/20, 14:52

  18. Georg Tiefenbrunn commented on patch set 3 V +1 CR +1 04/03/20, 14:54

    :)
  19. TYPO3com voted on patch set 3 V +1 04/03/20, 15:09 Completed build in 13m 37s on Fri, 3 Apr, 03:09 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2132

  20. Oliver Klee voted on patch set 3 CR +1 04/03/20, 15:27

  21. Georg Ringer voted on patch set 3 V +2 CR +2 04/03/20, 19:26

  22. Georg Ringer merged patch set 4 04/03/20, 19:26