64005[BUGFIX] Cast values passed to htmlspecialchars to string in ArrayBrowser
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Georg Tiefenbrunn +1
- Oliver Klee +1
-
Verified V +2 Done
- Georg Ringer +2
- Georg Tiefenbrunn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1822
-
Christian Eßl uploaded patch set 1 03/30/20, 11:24
-
TYPO3com voted on patch set 1 V -1 03/30/20, 11:40 Completed build in 14m 56s on Mon, 30 Mar, 11:40 AM Test Summary: 3 of 73540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1956
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/30/20, 11:49
-
TYPO3com commented on patch set 1 03/30/20, 12:12 Completed build in 1h 02m 01s on Mon, 30 Mar, 12:12 PM Test Summary: 3 of 73540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1956
-
Oliver Klee commented on patch set 1 03/30/20, 12:14
Is 9.5 affected as well? -
Christian Eßl commented on patch set 1 03/30/20, 12:26
Reply
No, reason for the error is a recent cleanup in master, that introduced strict type checks for the class. -
Oliver Klee voted on patch set 1 CR +1 03/30/20, 12:37
-
Julian Mair voted on patch set 1 CR +1 03/30/20, 17:49
-
Georg Tiefenbrunn commented on patch set 1 CR -1 04/02/20, 11:27
$value could also be numeric or boolean.ArrayBrowser.php:117Cast `$value` to string (could be `int` or `bool`) -
Alexander Schnitzler commented on patch set 1 04/02/20, 11:29
ArrayBrowser.php:117ReplyYes, what about this place? I ran into the error with this part not being a string. -
Andreas Kienast commented on patch set 1 04/02/20, 11:40
ArrayBrowser.php:117ReplyI guess it's about $value, not about $key -
Alexander Schnitzler commented on patch set 1 04/02/20, 18:58
ArrayBrowser.php:117Reply UnresolvedGot it. But let's not forget about the value. -
Andreas Kienast commented on patch set 2 04/03/20, 14:36
Published edit on patch set 1. -
Oliver Klee voted on patch set 2 CR +1 04/03/20, 14:41
-
TYPO3com voted on patch set 2 V +1 04/03/20, 14:48 Completed build in 12m 05s on Fri, 3 Apr, 02:48 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2127
-
Georg Tiefenbrunn commented on patch set 2 V +1 CR +1 04/03/20, 14:51
Consider altering the commit message: [BUGFIX] Cast values passed to htmlspecialchars to string in ArrayBrowser -
Christian Eßl updated the commit message in patch set 3 04/03/20, 14:52
-
Georg Tiefenbrunn commented on patch set 3 V +1 CR +1 04/03/20, 14:54
:) -
TYPO3com voted on patch set 3 V +1 04/03/20, 15:09 Completed build in 13m 37s on Fri, 3 Apr, 03:09 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2132
-
Oliver Klee voted on patch set 3 CR +1 04/03/20, 15:27
-
Georg Ringer voted on patch set 3 V +2 CR +2 04/03/20, 19:26
-
Georg Ringer merged patch set 4 04/03/20, 19:26