Review main Merged

64008[TASK] Raise versions of phpdocumentor dependencies

Benni Mack CR +2 V +2 Normal +40 −33 updated 04/01/20, 16:42

Commit message

Used composer command:
  composer req "phpdocumentor/type-resolver:^1.1.0" \
    "phpdocumentor/reflection-docblock:^5.1.0"

Output
  - Updating phpdocumentor/type-resolver (0.7.2 => 1.1.0)
  - Updating phpdocumentor/reflection-docblock (4.3.4 => 5.1.0)

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1225

  1. Benni Mack uploaded patch set 1 03/30/20, 11:59

  2. TYPO3com voted on patch set 1 V -1 03/30/20, 12:11 Completed build in 12m 45s on Mon, 30 Mar, 12:11 PM Test Summary: 10 of 73542 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1957

  3. Oliver Klee voted on patch set 1 CR +1 03/30/20, 12:15

  4. Benni Mack commented on patch set 1 03/30/20, 12:16

    Thank you, Oli!
  5. TYPO3com commented on patch set 1 03/30/20, 12:22 Completed build in 35m 55s on Mon, 30 Mar, 12:22 PM Test Summary: 8 of 73542 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1957

  6. TYPO3com commented on patch set 1 03/30/20, 12:30 Completed build in 1h 06m 58s on Mon, 30 Mar, 12:30 PM Test Summary: 3 of 73540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1957

  7. Georg Ringer rebased onto patch set 2 03/30/20, 18:07

  8. TYPO3com voted on patch set 2 V -1 03/30/20, 18:23 Completed build in 14m 45s on Mon, 30 Mar, 06:23 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1982

  9. TYPO3com commented on patch set 2 03/31/20, 09:14 Completed build in 15h 20m 46s on Tue, 31 Mar, 09:14 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1982

  10. TYPO3com commented on patch set 2 03/31/20, 09:45 Completed build in 6h 57m 21s on Tue, 31 Mar, 09:45 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1982

  11. Oliver Klee voted on patch set 2 CR +1 03/31/20, 11:24

  12. TYPO3com commented on patch set 2 03/31/20, 18:39 Completed build in 7h 28m 00s on Tue, 31 Mar, 06:39 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1982

  13. TYPO3com commented on patch set 2 03/31/20, 19:16 Completed build in 8h 35m 40s on Tue, 31 Mar, 07:16 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1982

  14. Benni Mack rebased onto patch set 3 03/31/20, 19:20

  15. TYPO3com voted on patch set 3 V -1 03/31/20, 19:32 Completed build in 12m 03s on Tue, 31 Mar, 07:32 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2033

  16. Oliver Klee voted on patch set 3 CR +1 04/01/20, 10:26

  17. Benni Mack uploaded patch set 4 04/01/20, 14:45

  18. TYPO3com voted on patch set 4 V -1 04/01/20, 14:58 Completed build in 12m 39s on Wed, 1 Apr, 02:58 PM Test Summary: 13 of 72916 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2056

  19. TYPO3com voted on patch set 4 V +1 04/01/20, 15:18 Completed build in 44m 59s on Wed, 1 Apr, 03:18 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2056

  20. TYPO3com voted on patch set 4 V -1 04/01/20, 15:19 Completed build in 10m 27s on Wed, 1 Apr, 03:19 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2057

  21. TYPO3com voted on patch set 4 V +1 04/01/20, 15:24 Completed build in 26m 18s on Wed, 1 Apr, 03:24 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2057

  22. Oliver Klee voted on patch set 4 CR +1 04/01/20, 15:37

  23. Andreas Kienast voted on patch set 4 V +1 CR +1 04/01/20, 16:17

  24. Susi Moog voted on patch set 4 V +2 CR +2 04/01/20, 16:42

  25. Susi Moog merged patch set 5 04/01/20, 16:42