Review main Merged

64012[TASK] Deprecate alternative fetch methods for GeneralUtility::getUrl()

Benni Mack CR +2 V +2 Normal +139 −53 updated 06/04/20, 12:59

Commit message

In times of PSR-7, TYPO3's RequestFactory API and the underlying
Guzzle HTTP library, the wrapper method GeneralUtility::getUrl() is merely
a lazy short-hand method for fetching the contents.

It is recommended to use TYPO3's RequestFactory API for fetching remote
URLs.

For now, however, the additional arguments (sending alternative headers,
only fetching HEAD requests and return headers or headers + content,
fetching a report of what happened) are deprecated, as they have
proven to be inflexible nowadays.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1218

  1. Benni Mack uploaded patch set 1 03/30/20, 13:06

  2. TYPO3com voted on patch set 1 V -1 03/30/20, 13:06 Completed build in 24s on Mon, 30 Mar, 01:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1963

  3. Benni Mack uploaded patch set 2 04/04/20, 20:13

  4. TYPO3com voted on patch set 2 V -1 04/04/20, 20:22 Completed build in 26s on Sat, 4 Apr, 08:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2176

  5. Benni Mack updated the commit message in patch set 3 04/05/20, 19:36

  6. TYPO3com voted on patch set 3 V -1 04/05/20, 19:39 Completed build in 25s on Sun, 5 Apr, 07:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2203

  7. Benni Mack uploaded patch set 4 04/05/20, 19:52

  8. TYPO3com voted on patch set 4 V -1 04/05/20, 20:09 Completed build in 17m 09s on Sun, 5 Apr, 08:09 PM Test Summary: 1360 of 73529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2204

  9. Benni Mack uploaded patch set 5 04/05/20, 20:25

  10. TYPO3com voted on patch set 5 V -1 04/05/20, 20:44 Completed build in 31s on Sun, 5 Apr, 08:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2205

  11. Andreas Kienast uploaded patch set 6 04/06/20, 04:50

  12. TYPO3com voted on patch set 6 V +1 04/06/20, 05:25 Completed build in 25m 41s on Mon, 6 Apr, 05:25 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2209

  13. Georg Ringer voted on patch set 6 V +1 CR +1 04/06/20, 15:42

  14. Andreas Kienast commented on patch set 6 CR -1 04/06/20, 16:12

    Indexer.php:704

    Is each header value really an array? And why do we implode them with an empty string?
  15. Benni Mack commented on patch set 6 04/06/20, 19:03

    Indexer.php:704 Reply Unresolved

    yes - it's like that "[Content-Type][0] = text/html". this is ugly, and in the next step of the Indexed Search Indexer refactoring, I will use the response object directly (saves one HTTP call).
  16. Andreas Kienast voted on patch set 6 V +2 CR +2 04/06/20, 19:28

  17. Andreas Kienast merged patch set 7 04/06/20, 19:28

  18. Markus Klein commented on patch set 7 06/04/20, 12:59

    PageContentErrorHandler.php:84 Unresolved

    We preserve all headers from this sub-request-response and pass them on. This might be problematic. See https://forge.typo3.org/issues/91582