64012[TASK] Deprecate alternative fetch methods for GeneralUtility::getUrl()
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageContentErrorHandler.php1+10 −5
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+6 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90956-AlternativeFetchMethodsAndReportsForGeneralUtilitygetUrl.rstnew+73 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −33
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.php+34 −0
- typo3/sysext/indexed_search/Classes/Indexer.php2+10 −12
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedStaticMatcher.php+6 −0
Review log 1218
-
Benni Mack uploaded patch set 1 03/30/20, 13:06
-
TYPO3com voted on patch set 1 V -1 03/30/20, 13:06 Completed build in 24s on Mon, 30 Mar, 01:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1963
-
Benni Mack uploaded patch set 2 04/04/20, 20:13
-
TYPO3com voted on patch set 2 V -1 04/04/20, 20:22 Completed build in 26s on Sat, 4 Apr, 08:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2176
-
Benni Mack updated the commit message in patch set 3 04/05/20, 19:36
-
TYPO3com voted on patch set 3 V -1 04/05/20, 19:39 Completed build in 25s on Sun, 5 Apr, 07:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2203
-
Benni Mack uploaded patch set 4 04/05/20, 19:52
-
TYPO3com voted on patch set 4 V -1 04/05/20, 20:09 Completed build in 17m 09s on Sun, 5 Apr, 08:09 PM Test Summary: 1360 of 73529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2204
-
Benni Mack uploaded patch set 5 04/05/20, 20:25
-
TYPO3com voted on patch set 5 V -1 04/05/20, 20:44 Completed build in 31s on Sun, 5 Apr, 08:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2205
-
Andreas Kienast uploaded patch set 6 04/06/20, 04:50
-
TYPO3com voted on patch set 6 V +1 04/06/20, 05:25 Completed build in 25m 41s on Mon, 6 Apr, 05:25 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2209
-
Georg Ringer voted on patch set 6 V +1 CR +1 04/06/20, 15:42
-
Andreas Kienast commented on patch set 6 CR -1 04/06/20, 16:12
-
Benni Mack commented on patch set 6 04/06/20, 19:03
Indexer.php:704Reply Unresolvedyes - it's like that "[Content-Type][0] = text/html". this is ugly, and in the next step of the Indexed Search Indexer refactoring, I will use the response object directly (saves one HTTP call). -
Andreas Kienast voted on patch set 6 V +2 CR +2 04/06/20, 19:28
-
Andreas Kienast merged patch set 7 04/06/20, 19:28
-
Markus Klein commented on patch set 7 06/04/20, 12:59
PageContentErrorHandler.php:84UnresolvedWe preserve all headers from this sub-request-response and pass them on. This might be problematic. See https://forge.typo3.org/issues/91582
Indexer.php:704