64016[TASK] Enable phpstan InvalidUnaryOperationRule
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1113
-
Alexander Schnitzler uploaded patch set 1 03/30/20, 15:16
-
Andreas Kienast commented on patch set 1 03/30/20, 15:26
-
TYPO3com voted on patch set 1 V +1 03/30/20, 15:29 Completed build in 12m 13s on Mon, 30 Mar, 03:29 PM Test Summary: 73056 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1969
-
Alexander Schnitzler commented on patch set 1 03/30/20, 15:50
DataMapProcessor.php:1155ReplyThat's true and I would be fine with casting the values to int as well. Either in this method or after all calls of this method. Then, we could keep the @return and still make phpstan happy. wdyt? -
Andreas Kienast commented on patch set 1 03/30/20, 15:55
DataMapProcessor.php:1155ReplyI think an additional array_map('intval', $filteredIds) is fine here. -
Alexander Schnitzler wrote 03/30/20, 16:29
Topic set to phpstan -
Alexander Schnitzler commented on patch set 1 03/30/20, 16:30
DataMapProcessor.php:1155Reply UnresolvedInside or outside this method? -
Alexander Schnitzler uploaded patch set 2 03/31/20, 08:26
-
TYPO3com voted on patch set 2 V +1 03/31/20, 08:38 Completed build in 11m 55s on Tue, 31 Mar, 08:38 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2010
-
Andreas Kienast voted on patch set 2 V +1 CR +1 04/06/20, 09:56
-
Oliver Klee voted on patch set 2 CR +1 04/06/20, 13:46
-
Georg Ringer voted on patch set 2 V +2 CR +2 04/07/20, 04:15
-
Georg Ringer merged patch set 3 04/07/20, 04:15
DataMapProcessor.php:1155