Review main Merged

64016[TASK] Enable phpstan InvalidUnaryOperationRule

Alexander Schnitzler CR +2 V +2 Easy +4 −3 updated 04/07/20, 04:15

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Alexander Schnitzler uploaded patch set 1 03/30/20, 15:16

  2. Andreas Kienast commented on patch set 1 03/30/20, 15:26

    DataMapProcessor.php:1155

    That's not quite correct: MU::canBeInterpretedAsInteger('1') (with a string) also returns true, which lets the array contain strings as well
  3. TYPO3com voted on patch set 1 V +1 03/30/20, 15:29 Completed build in 12m 13s on Mon, 30 Mar, 03:29 PM Test Summary: 73056 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1969

  4. Alexander Schnitzler commented on patch set 1 03/30/20, 15:50

    DataMapProcessor.php:1155 Reply

    That's true and I would be fine with casting the values to int as well. Either in this method or after all calls of this method. Then, we could keep the @return and still make phpstan happy. wdyt?
  5. Andreas Kienast commented on patch set 1 03/30/20, 15:55

    DataMapProcessor.php:1155 Reply

    I think an additional array_map('intval', $filteredIds) is fine here.
  6. Alexander Schnitzler wrote 03/30/20, 16:29

    Topic set to phpstan
  7. Alexander Schnitzler commented on patch set 1 03/30/20, 16:30

    DataMapProcessor.php:1155 Reply Unresolved

    Inside or outside this method?
  8. Alexander Schnitzler uploaded patch set 2 03/31/20, 08:26

  9. TYPO3com voted on patch set 2 V +1 03/31/20, 08:38 Completed build in 11m 55s on Tue, 31 Mar, 08:38 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2010

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 04/06/20, 09:56

  11. Oliver Klee voted on patch set 2 CR +1 04/06/20, 13:46

  12. Georg Ringer voted on patch set 2 V +2 CR +2 04/07/20, 04:15

  13. Georg Ringer merged patch set 3 04/07/20, 04:15