Review main Merged

64017[BUGFIX] Re-enable dynamic resolving of view objects

Alexander Schnitzler CR +2 V +2 Normal +137 −4 updated 04/15/20, 08:28

Commit message

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/59514/ all
possibilities have been taken to define which view class to use
based on the current plugin environment parameters like controller
name, action name and format. Since this is used a lot in user land
code, this functionality has been re-enabled for version 10. But
still, the main flaw of the original code, i.e. checking for
possibly defined classes, is avoided. Instead, users can implement
a deterministic view resolver which ensures view objects that
implement the ViewInterface.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 811

  1. Alexander Schnitzler uploaded patch set 1 03/30/20, 15:46

  2. Alexander Schnitzler wrote 03/30/20, 15:51

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 03/30/20, 15:58 Completed build in 11m 10s on Mon, 30 Mar, 03:58 PM Test Summary: 72163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1972

  4. TYPO3com voted on patch set 1 V +1 03/30/20, 16:20 Completed build in 45m 06s on Mon, 30 Mar, 04:20 PM Test Summary: 73053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1972

  5. Alexander Schnitzler commented on patch set 1 03/30/20, 16:28

    This change is ready for review.
  6. Alexander Schnitzler commented on patch set 1 04/13/20, 08:05

    ping
  7. Andreas Kienast uploaded patch set 2 04/14/20, 13:43

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 04/14/20, 13:45

  9. TYPO3com voted on patch set 2 V +1 04/14/20, 14:05 Completed build in 18m 35s on Tue, 14 Apr, 02:05 PM Test Summary: 73474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2507

  10. Daniel Goerz voted on patch set 2 V +2 CR +2 04/15/20, 08:28

  11. Daniel Goerz merged patch set 3 04/15/20, 08:28