64018[TASK] Enable phpstan DefaultValueTypesAssignedToPropertiesRule
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 24
- Build/phpstan.level3.neon+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+1 −1
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+2 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php+2 −2
- typo3/sysext/core/Classes/Messaging/Renderer/ListRenderer.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php2+1 −1
- typo3/sysext/extbase/Classes/Validation/Error.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+7 −7
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+1 −1
Review log 1115
-
Alexander Schnitzler uploaded patch set 1 03/30/20, 16:10
-
TYPO3com voted on patch set 1 V -1 03/30/20, 16:27 Completed build in 14m 16s on Mon, 30 Mar, 04:27 PM Test Summary: 72741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1977
-
Alexander Schnitzler wrote 03/30/20, 16:29
Topic set to phpstan -
Alexander Schnitzler commented on patch set 1 03/30/20, 16:30
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/30/20, 16:33 Completed build in 34m 13s on Mon, 30 Mar, 04:33 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1977
-
Christian Eßl voted on patch set 1 CR +1 03/30/20, 16:35
-
Oliver Klee commented on patch set 1 03/30/20, 17:10
Query.php:85Should this be the more specific int[]? -
Alexander Schnitzler commented on patch set 2 03/30/20, 18:06
Published edit on patch set 1. -
Alexander Schnitzler commented on patch set 2 03/30/20, 18:07
Query.php:85ReplyDone -
Oliver Klee commented on patch set 2 CR +1 03/30/20, 18:07
Neat! -
TYPO3com voted on patch set 2 V -1 03/30/20, 18:19 Completed build in 12m 14s on Mon, 30 Mar, 06:19 PM Test Summary: 73049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1981
-
TYPO3com voted on patch set 2 V +1 03/30/20, 18:46 Completed build in 51m 45s on Mon, 30 Mar, 06:46 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1981
-
Georg Ringer voted on patch set 2 V +1 CR +1 03/31/20, 03:52
-
Benni Mack voted on patch set 2 V +2 CR +2 04/06/20, 09:40
-
Benni Mack merged patch set 3 04/06/20, 09:40