Review main Merged

64018[TASK] Enable phpstan DefaultValueTypesAssignedToPropertiesRule

Alexander Schnitzler CR +2 V +2 Normal +34 −34 updated 04/06/20, 09:40

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1115

  1. Alexander Schnitzler uploaded patch set 1 03/30/20, 16:10

  2. TYPO3com voted on patch set 1 V -1 03/30/20, 16:27 Completed build in 14m 16s on Mon, 30 Mar, 04:27 PM Test Summary: 72741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1977

  3. Alexander Schnitzler wrote 03/30/20, 16:29

    Topic set to phpstan
  4. Alexander Schnitzler commented on patch set 1 03/30/20, 16:30

    This change is ready for review.
  5. TYPO3com voted on patch set 1 V +1 03/30/20, 16:33 Completed build in 34m 13s on Mon, 30 Mar, 04:33 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1977

  6. Christian Eßl voted on patch set 1 CR +1 03/30/20, 16:35

  7. Oliver Klee commented on patch set 1 03/30/20, 17:10

    Query.php:85

    Should this be the more specific int[]?
  8. Alexander Schnitzler commented on patch set 2 03/30/20, 18:06

    Published edit on patch set 1.
  9. Alexander Schnitzler commented on patch set 2 03/30/20, 18:07

    Query.php:85 Reply

    Done
  10. Oliver Klee commented on patch set 2 CR +1 03/30/20, 18:07

    Neat!
  11. TYPO3com voted on patch set 2 V -1 03/30/20, 18:19 Completed build in 12m 14s on Mon, 30 Mar, 06:19 PM Test Summary: 73049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1981

  12. TYPO3com voted on patch set 2 V +1 03/30/20, 18:46 Completed build in 51m 45s on Mon, 30 Mar, 06:46 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1981

  13. Georg Ringer voted on patch set 2 V +1 CR +1 03/31/20, 03:52

  14. Benni Mack voted on patch set 2 V +2 CR +2 04/06/20, 09:40

  15. Benni Mack merged patch set 3 04/06/20, 09:40