Review main Merged

64020[BUGFIX] Render custom preview before fluid preview in Page Module

Benni Mack CR +2 V +2 Easy +21 −28 updated 04/01/20, 12:51

Commit message

The code that executes the drawItem hook must be called before
the fluid-preview is rendered, in order to allow rendering of custom variables
within the Fluid preview.

This way, it behaves the same way as in the non-Fluidbased page module.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 611

  1. Benni Mack uploaded patch set 1 03/30/20, 20:31

  2. TYPO3com voted on patch set 1 V +1 03/30/20, 20:44 Completed build in 12m 25s on Mon, 30 Mar, 08:44 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1988

  3. Benni Mack updated the commit message in patch set 2 03/31/20, 09:38

  4. Benni Mack commented on patch set 2 03/31/20, 09:38

    This is related to the "PreviewPattern" feature that was added
  5. TYPO3com voted on patch set 2 V -1 03/31/20, 09:54 Completed build in 16m 21s on Tue, 31 Mar, 09:54 AM Test Summary: 18 of 73536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2017

  6. TYPO3com commented on patch set 2 03/31/20, 12:58 Completed build in 3h 35m 58s on Tue, 31 Mar, 12:58 PM Test Summary: 42 of 73536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2017

  7. TYPO3com commented on patch set 2 03/31/20, 13:57 Completed build in 7h 55m 03s on Tue, 31 Mar, 01:57 PM Test Summary: 35 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2017

  8. TYPO3com voted on patch set 2 V +1 03/31/20, 17:28 Completed build in 15h 44m 54s on Tue, 31 Mar, 05:28 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2017

  9. Achim Fritz voted on patch set 2 V +1 CR +1 04/01/20, 12:21

  10. Georg Ringer voted on patch set 2 V +2 CR +2 04/01/20, 12:51

  11. Georg Ringer merged patch set 3 04/01/20, 12:51