Review main Merged

64021[FEATURE] Introduce AssetRenderer BeforeRendering events

Jonas Eberle CR +2 V +2 Hard +411 −28 updated 04/14/20, 15:35

Commit message

AssetRenderer gets events for manipulating AssetCollector assets.

This enables asset post-processing extensions like EXT:min or
EXT:ws_scss to fully support AssetCollector assets.

The AssetCollector::add*() methods get an optional parameter that
allows filtering for (non-)priority assets. It became apararent during
testing that any listener would otherwise have to implement that
itself in order to avoid double-processing assets (as there are two
rendering passes, priority and non-priority).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 3458

Show 1733 earlier messages
  1. Jonas Eberle uploaded patch set 1 03/30/20, 22:25

  2. TYPO3com voted on patch set 1 V -1 03/30/20, 22:25 Completed build in 23s on Mon, 30 Mar, 10:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1994

  3. TYPO3com commented on patch set 1 03/30/20, 22:36 Completed build in 25s on Mon, 30 Mar, 10:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1995

  4. Jonas Eberle uploaded patch set 2 03/30/20, 22:46

  5. TYPO3com voted on patch set 2 V -1 03/30/20, 22:57 Completed build in 10m 35s on Mon, 30 Mar, 10:57 PM Test Summary: 491 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1996

  6. TYPO3com commented on patch set 2 03/30/20, 23:10 Completed build in 11m 44s on Mon, 30 Mar, 11:10 PM Test Summary: 491 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1997

  7. Benni Mack commented on patch set 2 04/01/20, 18:29

    AssetRenderer.php:42

    we could trigger an event right here... having everything coupled "BeforeRenderingEvent"? Then we only need one event.

    AssetRenderer.php:48

    how do you deal with $priority when triggering the event?
  8. Jonas Eberle commented on patch set 2 04/02/20, 14:46

    AssetRenderer.php:42 Reply Unresolved

    I don't think this is the right place here. We are not actually rendering yet. I agree that we could coerce it into 1 event, though: It keeps the class name shorter. Yet the consumer will want all the information that we have about the assets. @benni: Maybe you also have some other reasons in mind? Is it advantageous to have a small number of events in TYPO3?

    AssetRenderer.php:48 Reply Unresolved

    good point! Together with your idea that would be: BeforeRenderingEvent(AssetCollector, $priority, constant for JS/JSInline/CSS/CSSInline) Shall I do it like that?
  9. Jonas Eberle uploaded patch set 3 04/08/20, 10:03

  10. Jonas Eberle updated the commit message in patch set 4 04/08/20, 10:03

  11. Jonas Eberle updated the commit message in patch set 5 04/08/20, 10:06

  12. TYPO3com voted on patch set 3 V -1 04/08/20, 10:22 Completed build in 18m 14s on Wed, 8 Apr, 10:22 AM Test Summary: 491 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2291

  13. TYPO3com voted on patch set 4 V -1 04/08/20, 10:26 Completed build in 19m 37s on Wed, 8 Apr, 10:26 AM Test Summary: 491 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2292

  14. TYPO3com voted on patch set 5 V -1 04/08/20, 10:31 Completed build in 24m 10s on Wed, 8 Apr, 10:31 AM Test Summary: 491 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2293

  15. Jonas Eberle updated the commit message in patch set 6 04/08/20, 14:01

  16. Jonas Eberle uploaded patch set 7 04/08/20, 14:01

  17. Jonas Eberle uploaded patch set 8 04/08/20, 14:20

  18. TYPO3com voted on patch set 6 V -1 04/08/20, 14:41 Completed build in 28m 51s on Wed, 8 Apr, 02:41 PM Test Summary: 491 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2302

  19. TYPO3com voted on patch set 7 V -1 04/08/20, 14:46 Completed build in 33m 56s on Wed, 8 Apr, 02:46 PM Test Summary: 198 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2303

  20. TYPO3com voted on patch set 8 V -1 04/08/20, 14:56 Completed build in 14m 29s on Wed, 8 Apr, 02:56 PM Test Summary: 198 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2305

  21. Jonas Eberle uploaded patch set 9 04/08/20, 16:27

  22. Jonas Eberle uploaded patch set 10 04/08/20, 16:27

  23. Jonas Eberle uploaded patch set 11 04/08/20, 16:30

  24. TYPO3com commented on patch set 9 04/08/20, 16:40 Completed build in 13m 13s on Wed, 8 Apr, 04:40 PM Test Summary: 198 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2311

  25. TYPO3com voted on patch set 10 V -1 04/08/20, 16:46 Completed build in 19m 20s on Wed, 8 Apr, 04:46 PM Test Summary: 491 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2312

  26. TYPO3com voted on patch set 11 V -1 04/08/20, 16:53 Completed build in 17m 11s on Wed, 8 Apr, 04:53 PM Test Summary: 198 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2313

  27. Armin Vieweg voted on patch set 8 V +1 04/08/20, 17:09

  28. Jonas Eberle uploaded patch set 12 04/08/20, 19:00

  29. TYPO3com voted on patch set 12 V -1 04/08/20, 19:12 Completed build in 12m 11s on Wed, 8 Apr, 07:12 PM Test Summary: 6 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2320

  30. Jonas Eberle uploaded patch set 13 04/08/20, 19:53

  31. TYPO3com voted on patch set 13 V -1 04/08/20, 19:54 Completed build in 24s on Wed, 8 Apr, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2326

  32. TYPO3com commented on patch set 13 04/08/20, 20:00 Completed build in 22s on Wed, 8 Apr, 08:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2327

  33. Jonas Eberle uploaded patch set 14 04/08/20, 20:03

  1. TYPO3com voted on patch set 14 V +1 04/08/20, 20:23 Completed build in 16m 38s on Wed, 8 Apr, 08:23 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2329

  2. Jonas Eberle uploaded patch set 15 04/09/20, 08:17

  3. Jonas Eberle uploaded patch set 16 04/09/20, 09:18

  4. Jonas Eberle commented on patch set 16 04/09/20, 09:20

    I am really sorry for all the spamming. I should have tested locally before pushing all these noobish tries to deal with DI and tests... If the tests stay green, this is ready for review. I had problems with the AssetRenderer constructor instantiating the EventListenerDispatcher in existing tests. Please thoroughly review my approach there. There is a new unit test which checks for the event being dispatched and having correct properties.
  5. TYPO3com voted on patch set 15 V -1 04/09/20, 09:28 Completed build in 25m 15s on Thu, 9 Apr, 09:28 AM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2337

  6. TYPO3com voted on patch set 16 V -1 04/09/20, 10:27 Completed build in 42m 01s on Thu, 9 Apr, 10:27 AM Test Summary: 1 of 73902 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2339

  7. TYPO3com voted on patch set 16 V +1 04/09/20, 10:38 Completed build in 15m 15s on Thu, 9 Apr, 10:38 AM Test Summary: 73417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2341

  8. Jonas Eberle uploaded patch set 17 04/12/20, 06:50

  9. TYPO3com voted on patch set 17 V +1 04/12/20, 07:03 Completed build in 13m 02s on Sun, 12 Apr, 07:03 AM Test Summary: 73511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2388

  10. Jonas Eberle uploaded patch set 18 04/12/20, 07:12

  11. TYPO3com voted on patch set 18 V +1 04/12/20, 07:23 Completed build in 11m 04s on Sun, 12 Apr, 07:23 AM Test Summary: 73511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2389

  12. Jonas Eberle commented on patch set 18 04/12/20, 07:39

    We settled on 2 events (JavaScript/Stylesheets). The AssetCollector's get*() method got the possiblity to filter (non-)prioritized assets (optional param). Without that this logic would have had to be in each consuming listener which I found rather lacking.
  13. Jonas Eberle uploaded patch set 19 04/12/20, 09:08

  14. Jonas Eberle wrote 04/12/20, 09:09

    Description set to "One last docs update. No further patchsets coming for now."
  15. TYPO3com voted on patch set 19 V +1 04/12/20, 09:21 Completed build in 13m 16s on Sun, 12 Apr, 09:21 AM Test Summary: 73511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2390

  16. Anja Leichsenring commented on patch set 19 CR -2 04/12/20, 10:27

    we are in feature freeze, so this can't be merged before branching anymore. I add a block for now, as to avoid accidental merge.
  17. Benni Mack commented on patch set 19 04/12/20, 22:02

    Hey Anja, this is a missing piece for the AssetRenderer Feature introduced in TYPO3 v10.3. as all assets cannot be compressed or handled anymore by third-party extensions to move or extract them.
  18. Georg Ringer voted on patch set 19 V +1 CR +1 04/13/20, 08:05

  19. Jonas Eberle uploaded patch set 20 04/13/20, 08:07

  20. Jonas Eberle wrote 04/13/20, 08:08

    Description set to "Removed link to github repo"
  21. TYPO3com voted on patch set 20 V +1 04/13/20, 08:21 Completed build in 13m 12s on Mon, 13 Apr, 08:21 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2422

  22. Anja Leichsenring commented on patch set 20 CR 0 04/13/20, 08:22

    sign off by Benni accepted :) Removing the block.
  23. Benni Mack voted on patch set 20 V +1 CR +1 04/13/20, 10:15

  24. Georg Ringer voted on patch set 20 V +2 CR +2 04/14/20, 15:35

  25. Georg Ringer merged patch set 21 04/14/20, 15:35