Review 9.5 Merged

64028[TASK] Add Typo3Version class

Benni Mack CR +2 V +2 Normal +64 −0 updated 04/01/20, 12:47

Commit message

This class is a backport of the v10 equivalent, it is added
to ensure an easier upgrade path for v11 in the future, when
the constants will get removed.

Adding this class in TYPO3 v9 also helps to improve the release
process when packaging.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 03/31/20, 09:48

  2. TYPO3com voted on patch set 1 V +1 03/31/20, 10:14 Completed build in 20m 39s on Tue, 31 Mar, 10:14 AM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-391

  3. Benni Mack updated the commit message in patch set 2 03/31/20, 11:11

  4. Oliver Klee voted on patch set 2 CR +1 03/31/20, 11:12

  5. TYPO3com voted on patch set 2 V -1 03/31/20, 11:23 Completed build in 11m 52s on Tue, 31 Mar, 11:23 AM Test Summary: 73649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-392

  6. TYPO3com voted on patch set 2 V +1 03/31/20, 11:48 Completed build in 49m 15s on Tue, 31 Mar, 11:48 AM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-392

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/31/20, 12:53

  8. Markus Klein voted on patch set 2 V +1 CR +1 04/01/20, 12:38

  9. Markus Klein commented on patch set 2 04/01/20, 12:39

    But why not having all those methods static? There is no state in the class.
  10. Andreas Kienast voted on patch set 2 V +2 CR +2 04/01/20, 12:47

  11. Andreas Kienast merged patch set 3 04/01/20, 12:47