64028[TASK] Add Typo3Version class
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 811
-
Benni Mack uploaded patch set 1 03/31/20, 09:48
-
TYPO3com voted on patch set 1 V +1 03/31/20, 10:14 Completed build in 20m 39s on Tue, 31 Mar, 10:14 AM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-391
-
Benni Mack updated the commit message in patch set 2 03/31/20, 11:11
-
Oliver Klee voted on patch set 2 CR +1 03/31/20, 11:12
-
TYPO3com voted on patch set 2 V -1 03/31/20, 11:23 Completed build in 11m 52s on Tue, 31 Mar, 11:23 AM Test Summary: 73649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-392
-
TYPO3com voted on patch set 2 V +1 03/31/20, 11:48 Completed build in 49m 15s on Tue, 31 Mar, 11:48 AM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-392
-
Georg Ringer voted on patch set 2 V +1 CR +1 03/31/20, 12:53
-
Markus Klein voted on patch set 2 V +1 CR +1 04/01/20, 12:38
-
Markus Klein commented on patch set 2 04/01/20, 12:39
But why not having all those methods static? There is no state in the class. -
Andreas Kienast voted on patch set 2 V +2 CR +2 04/01/20, 12:47
-
Andreas Kienast merged patch set 3 04/01/20, 12:47