64030[TASK] Enable phpstan PHPStan\Rules\DeadCode\UnreachableStatementRule
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 15
- Build/phpstan.level4.neon+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+2 −1
- typo3/sysext/core/Classes/Service/FlexFormService.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/AndInterface.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/OrInterface.php+2 −2
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfigurationInterface.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −3
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+2 −2
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+1 −1
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+0 −1
- phpstan.neon+26 −0
Review log 711
-
Alexander Schnitzler uploaded patch set 1 03/31/20, 11:48
-
Alexander Schnitzler wrote 03/31/20, 11:49
Topic set to phpstan -
TYPO3com voted on patch set 1 V -1 03/31/20, 12:07 Completed build in 19m 03s on Tue, 31 Mar, 12:07 PM Test Summary: 12 of 73536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2022
-
Alexander Schnitzler uploaded patch set 2 03/31/20, 14:11
-
TYPO3com voted on patch set 2 V -1 03/31/20, 14:23 Completed build in 12m 11s on Tue, 31 Mar, 02:23 PM Test Summary: 40 of 73240 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2027
-
Oliver Klee voted on patch set 2 CR +1 03/31/20, 15:42
-
TYPO3com voted on patch set 2 V +1 03/31/20, 17:03 Completed build in 3h 04m 18s on Tue, 31 Mar, 05:03 PM Test Summary: 73048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2027
-
TYPO3com voted on patch set 1 V +1 03/31/20, 17:14 Completed build in 5h 44m 29s on Tue, 31 Mar, 05:14 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2022
-
Andreas Kienast voted on patch set 2 V +1 CR +1 04/02/20, 06:11
-
Georg Ringer voted on patch set 2 V +2 CR +2 04/02/20, 08:44
-
Georg Ringer merged patch set 3 04/02/20, 08:44