Review main Merged

64030[TASK] Enable phpstan PHPStan\Rules\DeadCode\UnreachableStatementRule

Alexander Schnitzler CR +2 V +2 Normal +43 −20 updated 04/02/20, 08:44

Commit message

Several issues have been ignored because of checks on runtime
constants which vary from context to context. Since we can
only simulate one context, phpstan is unable to properly
detect several paths.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 711

  1. Alexander Schnitzler uploaded patch set 1 03/31/20, 11:48

  2. Alexander Schnitzler wrote 03/31/20, 11:49

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 03/31/20, 12:07 Completed build in 19m 03s on Tue, 31 Mar, 12:07 PM Test Summary: 12 of 73536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2022

  4. Alexander Schnitzler uploaded patch set 2 03/31/20, 14:11

  5. TYPO3com voted on patch set 2 V -1 03/31/20, 14:23 Completed build in 12m 11s on Tue, 31 Mar, 02:23 PM Test Summary: 40 of 73240 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2027

  6. Oliver Klee voted on patch set 2 CR +1 03/31/20, 15:42

  7. TYPO3com voted on patch set 2 V +1 03/31/20, 17:03 Completed build in 3h 04m 18s on Tue, 31 Mar, 05:03 PM Test Summary: 73048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2027

  8. TYPO3com voted on patch set 1 V +1 03/31/20, 17:14 Completed build in 5h 44m 29s on Tue, 31 Mar, 05:14 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2022

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 04/02/20, 06:11

  10. Georg Ringer voted on patch set 2 V +2 CR +2 04/02/20, 08:44

  11. Georg Ringer merged patch set 3 04/02/20, 08:44