Review main Merged

64031[TASK] Enable phpstan PHPStan\Rules\Classes\ImpossibleInstanceOfRule

Alexander Schnitzler CR +2 V +2 Easy +25 −19 updated 04/16/20, 18:56

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1623

  1. Alexander Schnitzler uploaded patch set 1 03/31/20, 12:05

  2. TYPO3com voted on patch set 1 V -1 03/31/20, 12:22 Completed build in 15m 48s on Tue, 31 Mar, 12:22 PM Test Summary: 384 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2025

  3. Alexander Schnitzler wrote 03/31/20, 13:54

    Topic set to phpstan
  4. TYPO3com commented on patch set 1 03/31/20, 14:01 Completed build in 2h 11m 09s on Tue, 31 Mar, 02:01 PM Test Summary: 378 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2025

  5. TYPO3com commented on patch set 1 03/31/20, 17:13 Completed build in 7h 17m 46s on Tue, 31 Mar, 05:13 PM Test Summary: 351 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2025

  6. Alexander Schnitzler uploaded patch set 2 03/31/20, 17:45

  7. TYPO3com voted on patch set 2 V -1 03/31/20, 17:56 Completed build in 11m 31s on Tue, 31 Mar, 05:56 PM Test Summary: 72940 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2032

  8. TYPO3com voted on patch set 2 V +1 03/31/20, 18:01 Completed build in 27m 18s on Tue, 31 Mar, 06:01 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2032

  9. Oliver Klee voted on patch set 2 CR +1 03/31/20, 18:07

  10. Andreas Kienast commented on patch set 2 V +1 CR +1 04/02/20, 06:07

    ContentObjectRenderer.php:418

    This looks weird, but I think this comes from using ResourceFactory::retrieveFileOrFolderObject()
  11. Alexander Schnitzler commented on patch set 2 04/02/20, 09:06

    ContentObjectRenderer.php:418 Reply Unresolved

    Correct, it looks weird because FAL is weird.
  12. Alexander Schnitzler uploaded patch set 3 04/02/20, 09:08

  13. Alexander Schnitzler wrote 04/02/20, 09:08

    Description set to "manual rebase"
  14. TYPO3com voted on patch set 3 V +1 04/02/20, 09:27 Completed build in 18m 42s on Thu, 2 Apr, 09:27 AM Test Summary: 73051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2082

  15. Oliver Klee voted on patch set 3 CR +1 04/02/20, 09:52

  16. Andreas Kienast voted on patch set 3 V +1 CR +1 04/06/20, 09:52

  17. Daniel Goerz uploaded patch set 4 04/08/20, 20:02

  18. Daniel Goerz voted on patch set 4 V +1 CR +1 04/08/20, 20:04

  19. TYPO3com voted on patch set 4 V +1 04/08/20, 20:16 Completed build in 13m 54s on Wed, 8 Apr, 08:16 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2328

  20. Oliver Klee voted on patch set 4 CR +1 04/08/20, 21:20

  21. Alexander Schnitzler commented on patch set 4 04/16/20, 08:28

    ping
  22. Andreas Kienast voted on patch set 4 V +2 CR +2 04/16/20, 18:56

  23. Andreas Kienast merged patch set 5 04/16/20, 18:56