64031[TASK] Enable phpstan PHPStan\Rules\Classes\ImpossibleInstanceOfRule
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 6
- Build/phpstan.level4.neon+8 −8
- typo3/sysext/core/Classes/Cache/Backend/AbstractBackend.php+6 −8
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+1 −1
- phpstan.neon+8 −0
Review log 1623
-
Alexander Schnitzler uploaded patch set 1 03/31/20, 12:05
-
TYPO3com voted on patch set 1 V -1 03/31/20, 12:22 Completed build in 15m 48s on Tue, 31 Mar, 12:22 PM Test Summary: 384 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2025
-
Alexander Schnitzler wrote 03/31/20, 13:54
Topic set to phpstan -
TYPO3com commented on patch set 1 03/31/20, 14:01 Completed build in 2h 11m 09s on Tue, 31 Mar, 02:01 PM Test Summary: 378 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2025
-
TYPO3com commented on patch set 1 03/31/20, 17:13 Completed build in 7h 17m 46s on Tue, 31 Mar, 05:13 PM Test Summary: 351 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2025
-
Alexander Schnitzler uploaded patch set 2 03/31/20, 17:45
-
TYPO3com voted on patch set 2 V -1 03/31/20, 17:56 Completed build in 11m 31s on Tue, 31 Mar, 05:56 PM Test Summary: 72940 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2032
-
TYPO3com voted on patch set 2 V +1 03/31/20, 18:01 Completed build in 27m 18s on Tue, 31 Mar, 06:01 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2032
-
Oliver Klee voted on patch set 2 CR +1 03/31/20, 18:07
-
Andreas Kienast commented on patch set 2 V +1 CR +1 04/02/20, 06:07
ContentObjectRenderer.php:418This looks weird, but I think this comes from using ResourceFactory::retrieveFileOrFolderObject() -
Alexander Schnitzler commented on patch set 2 04/02/20, 09:06
ContentObjectRenderer.php:418Reply UnresolvedCorrect, it looks weird because FAL is weird. -
Alexander Schnitzler uploaded patch set 3 04/02/20, 09:08
-
Alexander Schnitzler wrote 04/02/20, 09:08
Description set to "manual rebase" -
TYPO3com voted on patch set 3 V +1 04/02/20, 09:27 Completed build in 18m 42s on Thu, 2 Apr, 09:27 AM Test Summary: 73051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2082
-
Oliver Klee voted on patch set 3 CR +1 04/02/20, 09:52
-
Andreas Kienast voted on patch set 3 V +1 CR +1 04/06/20, 09:52
-
Daniel Goerz uploaded patch set 4 04/08/20, 20:02
-
Daniel Goerz voted on patch set 4 V +1 CR +1 04/08/20, 20:04
-
TYPO3com voted on patch set 4 V +1 04/08/20, 20:16 Completed build in 13m 54s on Wed, 8 Apr, 08:16 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2328
-
Oliver Klee voted on patch set 4 CR +1 04/08/20, 21:20
-
Alexander Schnitzler commented on patch set 4 04/16/20, 08:28
ping -
Andreas Kienast voted on patch set 4 V +2 CR +2 04/16/20, 18:56
-
Andreas Kienast merged patch set 5 04/16/20, 18:56