Review main Merged

64032[TASK] Enable phpstan TernaryOperatorConstantConditionRule

Alexander Schnitzler CR +2 V +2 Easy +25 −18 updated 04/08/20, 19:58

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1216

  1. Alexander Schnitzler uploaded patch set 1 03/31/20, 14:50

  2. Alexander Schnitzler wrote 03/31/20, 14:50

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 03/31/20, 15:02 Completed build in 11m 44s on Tue, 31 Mar, 03:02 PM Test Summary: 14 of 73239 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2028

  4. TYPO3com voted on patch set 1 V +1 03/31/20, 17:08 Completed build in 2h 29m 49s on Tue, 31 Mar, 05:08 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2028

  5. Alexander Schnitzler commented on patch set 1 03/31/20, 17:08

    This change is ready for review.
  6. Oliver Klee voted on patch set 1 CR +1 03/31/20, 18:08

  7. Andreas Kienast voted on patch set 1 V +1 CR +1 04/02/20, 06:01

  8. Alexander Schnitzler uploaded patch set 2 04/07/20, 08:28

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 04/07/20, 08:29

  10. Alexander Schnitzler uploaded patch set 3 04/07/20, 08:30

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 04/07/20, 08:35

  12. TYPO3com voted on patch set 2 V -1 04/07/20, 08:40 Completed build in 11m 53s on Tue, 7 Apr, 08:40 AM Test Summary: 16 of 73847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2258

  13. TYPO3com voted on patch set 3 V +1 04/07/20, 08:46 Completed build in 15m 09s on Tue, 7 Apr, 08:46 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2259

  14. Oliver Klee voted on patch set 3 CR +1 04/07/20, 09:28

  15. Daniel Goerz voted on patch set 3 V +2 CR +2 04/08/20, 19:58

  16. Daniel Goerz merged patch set 4 04/08/20, 19:58