64034[TASK] Extract install tool session handler into SessionHandler API
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josef Glatz +1
-
Verified V +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Jonas Eberle +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1826
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 03/31/20, 16:18
-
TYPO3com voted on patch set 1 V +1 03/31/20, 16:29 Completed build in 11m 26s on Tue, 31 Mar, 04:29 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2029
-
Benni Mack updated the commit message in patch set 2 04/02/20, 20:46
-
TYPO3com voted on patch set 2 V +1 04/02/20, 21:04 Completed build in 16m 35s on Thu, 2 Apr, 09:04 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2108
-
Andreas Kienast voted on patch set 2 CR +1 04/06/20, 06:26
-
Jonas Eberle commented on patch set 2 V +1 04/12/20, 20:23
I hope I tested this correctly. I deleted all cookies and navigated to typo3/install.php - the Typo3InstallTool cookie gets set but the session is not logged in yet. Logging in works, session is maintained. Clicked around, tried AJAX things. A parallel session in another browser works as well and login state is managed seperately for both. Looks good. -
Jonas Eberle commented on patch set 2 04/12/20, 20:25
Tested access via the backend, too. -
Andreas Kienast uploaded patch set 3 04/13/20, 13:01
-
Andreas Kienast voted on patch set 3 V +1 CR +1 04/13/20, 13:01
-
TYPO3com voted on patch set 3 V -1 04/13/20, 13:35 Completed build in 34m 01s on Mon, 13 Apr, 01:35 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2443
-
TYPO3com commented on patch set 3 04/13/20, 13:40 Completed build in 1h 13m 22s on Mon, 13 Apr, 01:40 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2443
-
Jonas Eberle voted on patch set 3 V +1 04/13/20, 13:45
-
TYPO3com voted on patch set 3 V +1 04/13/20, 14:06 Completed build in 2h 18m 26s on Mon, 13 Apr, 02:06 PM Test Summary: 73409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2443
-
Josef Glatz uploaded patch set 4 04/14/20, 06:41
-
Josef Glatz uploaded patch set 5 04/14/20, 06:42
-
Josef Glatz commented on patch set 5 04/14/20, 06:43
FileSessionHandler.php:35Should we remove default value, since $sessionPath is always overridden in the constructor?FileSessionHandler.php:42Same as for $sessionPath: This property is always overridden in the constructor. Should we clear the default value?FileSessionHandler.php:183The return value is bool. PHPDoc states a string as return value. The interface declares a bool as return value. Is this on purpose? -
TYPO3com voted on patch set 4 V +1 04/14/20, 06:53 Completed build in 12m 29s on Tue, 14 Apr, 06:53 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2472
-
TYPO3com voted on patch set 5 V +1 04/14/20, 06:59 Completed build in 15m 40s on Tue, 14 Apr, 06:59 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2473
-
Benni Mack commented on patch set 5 04/14/20, 10:19
FileSessionHandler.php:35ReplyI don't care here. You are right technically of course. Just tried to stay as similar as possible from the existing code. -
Benni Mack commented on patch set 5 04/14/20, 10:24
FileSessionHandler.php:183Replynope. we need to update the docblock then -
Josef Glatz uploaded patch set 6 04/14/20, 10:31
-
Josef Glatz commented on patch set 6 V +1 CR +1 04/14/20, 10:31
FileSessionHandler.php:35ReplyDoneFileSessionHandler.php:42ReplyDoneFileSessionHandler.php:183ReplyDone -
Jonas Eberle voted on patch set 6 V +1 04/14/20, 10:37
-
TYPO3com voted on patch set 6 V +1 04/14/20, 10:42 Completed build in 11m 34s on Tue, 14 Apr, 10:42 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2482
-
Georg Ringer voted on patch set 6 V +2 CR +2 04/14/20, 15:19
-
Georg Ringer merged patch set 7 04/14/20, 15:19