Review main Merged

64035[TASK] Improve deprecation messages in ExtensionUtility

Alexander Schnitzler CR +2 V +2 Easy +6 −5 updated 04/14/20, 15:36

Commit message

This patch enriches the deprecation messages with important
information such as extension, plugin and vendor name to be
able to distinguish deprecation messages from each other and
to ease the location of affected code.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Alexander Schnitzler uploaded patch set 1 03/31/20, 16:22

  2. TYPO3com voted on patch set 1 V +1 03/31/20, 16:35 Completed build in 12m 09s on Tue, 31 Mar, 04:35 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2030

  3. Alexander Schnitzler updated the commit message in patch set 2 03/31/20, 16:54

  4. TYPO3com voted on patch set 2 V +1 03/31/20, 17:06 Completed build in 11m 34s on Tue, 31 Mar, 05:05 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2031

  5. Andreas Kienast voted on patch set 2 CR +1 04/01/20, 06:22

  6. Alexander Schnitzler commented on patch set 2 04/01/20, 06:31

    "location" needs to be "locating". It's a grammar issue we should adjust shortly before merging this patch.
  7. Alexander Schnitzler wrote 04/01/20, 09:31

    Topic set to extbase
  8. Oliver Klee commented on patch set 2 CR +1 04/01/20, 10:25

    Reply Unresolved

    And the "the" and the "to" then eeds to go away, too: "to ease locating affected code"
  9. Benni Mack voted on patch set 2 V +1 CR +1 04/13/20, 08:39

  10. Georg Ringer voted on patch set 2 V +2 CR +2 04/14/20, 15:36

  11. Georg Ringer merged patch set 3 04/14/20, 15:36