Review main Abandoned

64036[BUGFIX] Fix failing composer max nightly tests

Alexander Schnitzler CR 0 V 0 Easy +1 −6 updated 04/13/20, 13:31

Commit message

When updating all dependencies prior to executing tests, the
AbstractExceptionHandlerTest failed due to the instantiation
of an abstract class which didn't comply with the interface
contract of ExceptionHandlerInterface which made the existence
of a cnstructor mandatory.

To fix this issue, the constructor method has been removed
from the interface. This is a non breaking change as removing
methods from interfaces do not result in a need to adjust
concrete implementations.

Also, defining constructors in interfaces is a code smell the
least because interfaces are a way to describe behaviour of
an implementation. How implementations are constructed is a
different issue.

In this case, the interface contained the constructor method
to indicate that an ExceptionHandler needs a constructor as
the current implementations of exception handlers register
themselves via set_exception_handler. This however is not the
scope of interfaces. Interfaces define how an object behaves,
seen from the outside. The interface must only define how an
exception handler handles exceptions, how it is registered
is a different topic.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 713

  1. Alexander Schnitzler uploaded patch set 1 04/01/20, 07:38

  2. TYPO3com voted on patch set 1 V -1 04/01/20, 07:51 Completed build in 12m 07s on Wed, 1 Apr, 07:51 AM Test Summary: 1 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2040

  3. TYPO3com commented on patch set 1 04/01/20, 08:25 Completed build in 1h 33m 01s on Wed, 1 Apr, 08:25 AM Test Summary: 1 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2040

  4. TYPO3com commented on patch set 1 04/01/20, 08:32 Completed build in 2h 26m 43s on Wed, 1 Apr, 08:32 AM Test Summary: 1 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2040

  5. TYPO3com commented on patch set 1 04/01/20, 09:42 Completed build in 4h 30m 37s on Wed, 1 Apr, 09:42 AM Test Summary: 1 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2040

  6. TYPO3com commented on patch set 1 04/01/20, 10:12 Completed build in 7h 04m 09s on Wed, 1 Apr, 10:12 AM Test Summary: 1 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2040

  7. Oliver Klee voted on patch set 1 CR +1 04/01/20, 10:24

  8. TYPO3com voted on patch set 1 V +1 04/01/20, 17:09 Completed build in 16h 34m 24s on Wed, 1 Apr, 05:09 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2040

  9. Alexander Schnitzler commented on patch set 1 04/01/20, 17:21

    This change is ready for review.
  10. Benni Mack voted on patch set 1 V +1 CR +1 04/04/20, 21:14

  11. Alexander Schnitzler commented on patch set 1 04/05/20, 07:52

    Do we still need this patch after the merge of Anjas patch? See https://review.typo3.org/c/Packages/TYPO3.CMS/+/64066 This patch would boil down to the removal of the constructor from the interface which can also be done in 11.0.
  12. Anja Leichsenring commented on patch set 1 04/13/20, 08:21

    sorry for the late reply, I never saw that patch. It is not needed anymore for fixing tests, and I would prefer to change an interface in the early stage of a version, not mere days from final release.
  13. Alexander Schnitzler abandoned the change 04/13/20, 13:31

    Not needed.