64037[WIP][!!!][FEATURE] Replace TypoScript with YAML
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 153
- typo3/sysext/belog/Configuration/TypoScript/setup.typoscriptdeleted+0 −34
- typo3/sysext/belog/Configuration/TypoScript/setup.yamlnew+28 −0
- typo3/sysext/belog/ext_typoscript_setup.typoscriptdeleted+0 −1
- typo3/sysext/belog/ext_typoscript_setup.yamlnew+2 −0
- typo3/sysext/beuser/Configuration/TypoScript/setup.typoscriptdeleted+0 −14
- typo3/sysext/beuser/Configuration/TypoScript/setup.yamlnew+6 −0
- typo3/sysext/beuser/ext_typoscript_setup.typoscriptdeleted+0 −1
- typo3/sysext/beuser/ext_typoscript_setup.yaml1new+2 −0
- typo3/sysext/core/Classes/Command/ConvertTypoScriptToYaml.phpnew+62 −0
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+4 −2
- typo3/sysext/core/Configuration/Services.yaml+6 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TypoScript/constants.typoscriptdeleted+0 −15
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TypoScript/constants.yamlnew+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TypoScript/setup.typoscriptdeleted+0 −43
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TypoScript/setup.yamlnew+10 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page1.typoscriptdeleted+0 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page1.yamlnew+12 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page2.typoscriptdeleted+0 −22
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page2.yamlnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page3.typoscriptdeleted+0 −22
Show 133 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page3.yamlnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page4.typoscriptdeleted+0 −22
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page4.yamlnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page5.typoscriptdeleted+0 −22
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page5.yamlnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/ExtbaseJsonRenderer.typoscriptdeleted+0 −15
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/ExtbaseJsonRenderer.yaml1new+12 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscriptdeleted+0 −271
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.yamlnew+387 −0
- typo3/sysext/core/Tests/Unit/Configuration/Loader/Fixtures/included.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Unit/Configuration/Loader/Fixtures/included.yamlnew+1 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Fixtures/recursive_includes_setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Unit/TypoScript/Fixtures/recursive_includes_setup.yamlnew+1 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Fixtures/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Unit/TypoScript/Fixtures/setup.yamlnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/DefaultStyles/setup.typoscriptdeleted+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/DefaultStyles/setup.yamlnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/constants.typoscriptdeleted+0 −30
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/constants.yamlnew+17 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/setup.typoscriptdeleted+0 −69
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/setup.yamlnew+48 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/ContentJsonRenderer.typoscriptdeleted+0 −32
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/ContentJsonRenderer.yamlnew+29 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/JsonRenderer.typoscriptdeleted+0 −32
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/JsonRenderer.yamlnew+29 −0
- typo3/sysext/extbase/ext_typoscript_setup.typoscriptdeleted+0 −15
- typo3/sysext/extbase/ext_typoscript_setup.yamlnew+10 −0
- typo3/sysext/extensionmanager/ext_typoscript_setup.typoscriptdeleted+0 −6
- typo3/sysext/extensionmanager/ext_typoscript_setup.yamlnew+4 −0
- typo3/sysext/felogin/Configuration/TypoScript/PiBase/constants.typoscriptdeleted+0 −4
- typo3/sysext/felogin/Configuration/TypoScript/PiBase/constants.yamlnew+4 −0
- typo3/sysext/felogin/Configuration/TypoScript/PiBase/setup.typoscriptdeleted+0 −104
- typo3/sysext/felogin/Configuration/TypoScript/PiBase/setup.yamlnew+116 −0
- typo3/sysext/felogin/Configuration/TypoScript/constants.typoscriptdeleted+0 −60
- typo3/sysext/felogin/Configuration/TypoScript/constants.yamlnew+26 −0
- typo3/sysext/felogin/Configuration/TypoScript/setup.typoscriptdeleted+0 −29
- typo3/sysext/felogin/Configuration/TypoScript/setup.yamlnew+19 −0
- typo3/sysext/fluid/ext_typoscript_setup.typoscriptdeleted+0 −17
- typo3/sysext/fluid/ext_typoscript_setup.yamlnew+14 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Bullets.typoscriptdeleted+0 −38
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Bullets.yamlnew+29 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Div.typoscriptdeleted+0 −9
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Div.yamlnew+4 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Header.typoscriptdeleted+0 −16
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Header.yamlnew+10 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Html.typoscriptdeleted+0 −16
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Html.yamlnew+10 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Image.typoscriptdeleted+0 −29
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Image.yamlnew+21 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/List.typoscriptdeleted+0 −15
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/List.yamlnew+9 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuAbstract.typoscriptdeleted+0 −28
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuAbstract.yamlnew+21 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuCategorizedContent.typoscriptdeleted+0 −37
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuCategorizedContent.yamlnew+31 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuCategorizedPages.typoscriptdeleted+0 −33
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuCategorizedPages.yamlnew+25 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuPages.typoscriptdeleted+0 −28
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuPages.yamlnew+21 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuRecentlyUpdated.typoscriptdeleted+0 −32
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuRecentlyUpdated.yamlnew+23 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuRelatedPages.typoscriptdeleted+0 −32
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuRelatedPages.yamlnew+23 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSection.typoscriptdeleted+0 −52
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSection.yamlnew+39 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSectionPages.typoscriptdeleted+0 −41
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSectionPages.yamlnew+33 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSitemap.typoscriptdeleted+0 −27
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSitemap.yamlnew+18 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSitemapPages.typoscriptdeleted+0 −29
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSitemapPages.yamlnew+22 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSubpages.typoscriptdeleted+0 −28
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/MenuSubpages.yamlnew+21 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Shortcut.typoscriptdeleted+0 −23
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Shortcut.yamlnew+15 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Table.typoscriptdeleted+0 −39
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Table.yamlnew+32 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Text.typoscriptdeleted+0 −16
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Text.yamlnew+10 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Textmedia.typoscriptdeleted+0 −29
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Textmedia.yamlnew+21 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Textpic.typoscriptdeleted+0 −29
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Textpic.yamlnew+21 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Uploads.typoscriptdeleted+0 −24
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Uploads.yamlnew+20 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscriptdeleted+0 −42
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.yamlnew+36 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscriptdeleted+0 −119
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.yamlnew+183 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Styling/setup.typoscriptdeleted+0 −80
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Styling/setup.yamlnew+3 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/constants.typoscriptdeleted+0 −63
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/constants.yamlnew+31 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/setup.typoscriptdeleted+0 −48
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/setup.yamlnew+10 −0
- typo3/sysext/form/Configuration/TypoScript/setup.typoscriptdeleted+0 −32
- typo3/sysext/form/Configuration/TypoScript/setup.yamlnew+22 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/TitleTagRenderingTest.typoscriptdeleted+0 −18
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/TitleTagRenderingTest.yamlnew+3 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/UriPrefixRenderingTest.typoscriptdeleted+0 −55
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/UriPrefixRenderingTest.yamlnew+25 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/JsonRenderer.typoscriptdeleted+0 −13
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/JsonRenderer.yamlnew+11 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkGenerator.typoscriptdeleted+0 −15
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkGenerator.yamlnew+15 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkRequest.typoscriptdeleted+0 −25
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkRequest.yamlnew+27 −0
- typo3/sysext/indexed_search/Configuration/TypoScript/constants.typoscriptdeleted+0 −16
- typo3/sysext/indexed_search/Configuration/TypoScript/constants.yamlnew+9 −0
- typo3/sysext/indexed_search/Configuration/TypoScript/setup.typoscriptdeleted+0 −126
- typo3/sysext/indexed_search/Configuration/TypoScript/setup.yamlnew+73 −0
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/constants.typoscriptdeleted+0 −21
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/constants.yamlnew+12 −0
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.typoscriptdeleted+0 −57
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.yamlnew+38 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/content.typoscriptdeleted+0 −25
- typo3/sysext/seo/Tests/Functional/Fixtures/content.yamlnew+18 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/HrefLang.typoscriptdeleted+0 −12
- typo3/sysext/seo/Tests/Functional/Fixtures/HrefLang.yamlnew+10 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/page1.typoscriptdeleted+0 −5
- typo3/sysext/seo/Tests/Functional/Fixtures/page1.yamlnew+3 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/page2.typoscriptdeleted+0 −6
- typo3/sysext/seo/Tests/Functional/Fixtures/page2.yamlnew+4 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/page3.typoscriptdeleted+0 −7
- typo3/sysext/seo/Tests/Functional/Fixtures/page3.yamlnew+6 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/records.typoscriptdeleted+0 −55
- typo3/sysext/seo/Tests/Functional/Fixtures/records.yamlnew+40 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl1.typoscriptdeleted+0 −5
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl1.yamlnew+4 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl2.typoscriptdeleted+0 −6
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl2.yamlnew+6 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl3.typoscriptdeleted+0 −13
- typo3/sysext/seo/Tests/Functional/Fixtures/sitemap-xsl3.yamlnew+9 −0
Review log 1623
-
Andreas Kienast uploaded patch set 1 04/01/20, 07:51
-
TYPO3com voted on patch set 1 V -1 04/01/20, 07:52 Completed build in 23s on Wed, 1 Apr, 07:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2041
-
Andreas Kienast uploaded patch set 2 04/01/20, 07:52
-
TYPO3com voted on patch set 2 V -1 04/01/20, 07:52 Completed build in 23s on Wed, 1 Apr, 07:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2042
-
Frank Nägler commented on patch set 2 CR -1 04/01/20, 07:56
-
Andreas Kienast uploaded patch set 3 04/01/20, 07:56
-
TYPO3com voted on patch set 3 V -1 04/01/20, 07:56 Completed build in 22s on Wed, 1 Apr, 07:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2043
-
Andreas Kienast uploaded patch set 4 04/01/20, 07:57
-
TYPO3com voted on patch set 4 V -1 04/01/20, 07:57 Completed build in 22s on Wed, 1 Apr, 07:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2044
-
Mathias Brodala commented on patch set 4 04/01/20, 07:57
Have you considered msgpack instead for better performance? -
Frank Nägler commented on patch set 4 CR -1 04/01/20, 07:58
ExtbaseJsonRenderer.yaml:1Unresolvedhere is also a include missing -
Benni Mack voted on patch set 4 CR +1 04/01/20, 08:29
-
Oliver Hader commented on patch set 4 V +1 CR -1 04/01/20, 08:46
Clean & straight forward, but I really advise to have tests here to cover the new YAML. This also might be a good start for defining a schema for all cObjects and properties... But probably we should use a different file extension, e.g. `.typoscript.yaml` or as a combined version `.yatsl` (yet another TS lang) or just `.tysonml` (TYpoScript Object Notation Markup Lang). What do you think? -
Andreas Kienast commented on patch set 4 04/01/20, 08:57
> Patch Set 4: Verified+1 Code-Review-1 > > But probably we should use a different file extension, e.g. `.typoscript.yaml` or as a combined version `.yatsl` (yet another TS lang) or just `.tysonml` (TYpoScript Object Notation Markup Lang). I love yatsl, this preserves our origins. Personally, I'm against tysonml as I fear copyright infringements from former boxers. -
Daniel Goerz voted on patch set 4 CR +1 04/01/20, 09:06
-
Oliver Hader commented on patch set 4 04/01/20, 09:12
Did somebody look into Bamboo results? I really don't know why it fails... Everything works fine on my local machine - and also it seems to be faster than before, probably since TypoScript parsing is not done anymore (which is a positive side-effect I would not have expected). -
Andreas Kienast uploaded patch set 5 04/01/20, 09:18
-
Josef Glatz updated the commit message in patch set 6 04/01/20, 09:25
-
Josef Glatz updated the commit message in patch set 7 04/01/20, 09:27
-
TYPO3com voted on patch set 5 V -1 04/01/20, 09:29 Completed build in 10m 51s on Wed, 1 Apr, 09:29 AM Test Summary: 5907 of 73231 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2048
-
TYPO3com voted on patch set 6 V -1 04/01/20, 09:39 Completed build in 13m 41s on Wed, 1 Apr, 09:39 AM Test Summary: 6031 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2049
-
TYPO3com voted on patch set 7 V -1 04/01/20, 09:43 Completed build in 15m 03s on Wed, 1 Apr, 09:43 AM Test Summary: 6049 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2050
-
Andreas Kienast abandoned the change 04/02/20, 05:06
It seems this was a not so obvious April fool. However, 1st of April is over, thus abandon (for now?)
ext_typoscript_setup.yaml:1Unresolved