Review main Abandoned Breaking

64037[WIP][!!!][FEATURE] Replace TypoScript with YAML

Andreas Kienast CR 0 V 0 Nightmare +2020 −2413 updated 04/02/20, 05:06

Commit message

In order to use open standards, TypoScript is replaced with YAML.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 153

Show 133 more files

Review log 1623

  1. Andreas Kienast uploaded patch set 1 04/01/20, 07:51

  2. TYPO3com voted on patch set 1 V -1 04/01/20, 07:52 Completed build in 23s on Wed, 1 Apr, 07:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2041

  3. Andreas Kienast uploaded patch set 2 04/01/20, 07:52

  4. TYPO3com voted on patch set 2 V -1 04/01/20, 07:52 Completed build in 23s on Wed, 1 Apr, 07:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2042

  5. Frank Nägler commented on patch set 2 CR -1 04/01/20, 07:56

    ext_typoscript_setup.yaml:1 Unresolved

    include missing here
  6. Andreas Kienast uploaded patch set 3 04/01/20, 07:56

  7. TYPO3com voted on patch set 3 V -1 04/01/20, 07:56 Completed build in 22s on Wed, 1 Apr, 07:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2043

  8. Andreas Kienast uploaded patch set 4 04/01/20, 07:57

  9. TYPO3com voted on patch set 4 V -1 04/01/20, 07:57 Completed build in 22s on Wed, 1 Apr, 07:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2044

  10. Mathias Brodala commented on patch set 4 04/01/20, 07:57

    Have you considered msgpack instead for better performance?
  11. Frank Nägler commented on patch set 4 CR -1 04/01/20, 07:58

    ExtbaseJsonRenderer.yaml:1 Unresolved

    here is also a include missing
  12. Benni Mack voted on patch set 4 CR +1 04/01/20, 08:29

  13. Oliver Hader commented on patch set 4 V +1 CR -1 04/01/20, 08:46

    Clean & straight forward, but I really advise to have tests here to cover the new YAML. This also might be a good start for defining a schema for all cObjects and properties... But probably we should use a different file extension, e.g. `.typoscript.yaml` or as a combined version `.yatsl` (yet another TS lang) or just `.tysonml` (TYpoScript Object Notation Markup Lang). What do you think?
  14. Andreas Kienast commented on patch set 4 04/01/20, 08:57

    > Patch Set 4: Verified+1 Code-Review-1 > > But probably we should use a different file extension, e.g. `.typoscript.yaml` or as a combined version `.yatsl` (yet another TS lang) or just `.tysonml` (TYpoScript Object Notation Markup Lang). I love yatsl, this preserves our origins. Personally, I'm against tysonml as I fear copyright infringements from former boxers.
  15. Daniel Goerz voted on patch set 4 CR +1 04/01/20, 09:06

  16. Oliver Hader commented on patch set 4 04/01/20, 09:12

    Did somebody look into Bamboo results? I really don't know why it fails... Everything works fine on my local machine - and also it seems to be faster than before, probably since TypoScript parsing is not done anymore (which is a positive side-effect I would not have expected).
  17. Andreas Kienast uploaded patch set 5 04/01/20, 09:18

  18. Josef Glatz updated the commit message in patch set 6 04/01/20, 09:25

  19. Josef Glatz updated the commit message in patch set 7 04/01/20, 09:27

  20. TYPO3com voted on patch set 5 V -1 04/01/20, 09:29 Completed build in 10m 51s on Wed, 1 Apr, 09:29 AM Test Summary: 5907 of 73231 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2048

  21. TYPO3com voted on patch set 6 V -1 04/01/20, 09:39 Completed build in 13m 41s on Wed, 1 Apr, 09:39 AM Test Summary: 6031 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2049

  22. TYPO3com voted on patch set 7 V -1 04/01/20, 09:43 Completed build in 15m 03s on Wed, 1 Apr, 09:43 AM Test Summary: 6049 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2050

  23. Andreas Kienast abandoned the change 04/02/20, 05:06

    It seems this was a not so obvious April fool. However, 1st of April is over, thus abandon (for now?)