Review main Merged

64038[BUGFIX] Enable rootline / content access to sysfolders

Benni Mack CR +2 V +2 Easy +30 −7 updated 12/08/20, 20:49

Commit message

Only disallow DOCTYPE_RECYCLER in rootline and cObj->checkPid(),
instead of disallowing DOCTYPE_SYSFOLDER.

This makes it possible to fetch content from sysfolder pages.

At the same time, a hard check on accessing sys folders is added
to TSFE.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 5

Review log 1722

  1. Benni Mack uploaded patch set 1 04/01/20, 08:36

  2. TYPO3com voted on patch set 1 V -1 04/01/20, 08:48 Completed build in 11m 46s on Wed, 1 Apr, 08:48 AM Test Summary: 51 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2045

  3. Dmitry Dulepov voted on patch set 1 CR +1 04/01/20, 09:43

  4. Henrik Ziegenhain voted on patch set 1 CR +1 04/01/20, 12:15

  5. Benni Mack uploaded patch set 2 04/01/20, 15:23

  6. TYPO3com voted on patch set 2 V -1 04/01/20, 15:34 Completed build in 10m 48s on Wed, 1 Apr, 03:34 PM Test Summary: 3 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2058

  7. Benni Mack uploaded patch set 3 04/01/20, 15:50

  8. TYPO3com voted on patch set 3 V -1 04/01/20, 16:01 Completed build in 10m 47s on Wed, 1 Apr, 04:01 PM Test Summary: 73040 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2059

  9. TYPO3com voted on patch set 3 V +1 04/01/20, 16:49 Completed build in 1h 09m 25s on Wed, 1 Apr, 04:49 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2059

  10. Susi Moog voted on patch set 3 CR +1 04/01/20, 16:54

  11. Wouter Wolters voted on patch set 3 CR +1 04/01/20, 18:31

  12. Henrik Ziegenhain voted on patch set 3 CR +1 04/02/20, 04:37

  13. Dmitry Dulepov voted on patch set 3 CR +1 04/02/20, 05:23

  14. Josef Glatz commented on patch set 3 04/02/20, 05:25

    Benni, regarding #18079: I'm aware of the situation, but such change can lead to unexpected results after upgrading from an older TYPO3 instance? Background: I'm used the existing situation (sysfolder stops sliding) explicitly when using slide of cObj `CONTENT` sometimes. Therefore: is this probably an "IMPORTANT" change so that we need an rST?
  15. Benni Mack commented on patch set 3 04/02/20, 07:54

    > Patch Set 3: > > Benni, regarding #18079: > > I'm aware of the situation, but such change can lead to unexpected results after upgrading from an older TYPO3 instance? Background: I'm used the existing situation (sysfolder stops sliding) explicitly when using slide of cObj `CONTENT` sometimes. > > Therefore: is this probably an "IMPORTANT" change so that we need an rST? fine with me, I can prepare something.
  16. Benni Mack uploaded patch set 4 04/02/20, 18:56

  17. TYPO3com voted on patch set 4 V +1 04/02/20, 19:08 Completed build in 11m 48s on Thu, 2 Apr, 07:08 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2104

  18. Susi Moog voted on patch set 4 V +1 CR +1 04/04/20, 06:38

  19. Oli Bartsch voted on patch set 4 V +1 CR +1 04/04/20, 08:24

  20. Georg Ringer voted on patch set 4 V +2 CR +2 04/04/20, 11:11

  21. Georg Ringer merged patch set 5 04/04/20, 11:11

  22. Markus Klein commented on patch set 5 12/08/20, 20:49

    There seems to be a regression to this: https://forge.typo3.org/issues/92762