Review main Merged

64039[TASK] Separate configuration into hooks for Indexer

Benni Mack CR +2 V +2 Hard +270 −258 updated 04/03/20, 14:37

Commit message

This is a pre-patch to separate crawler-specific implementation from
the actual indexing configuration.

This first patch unifies the configuration creation for the indexer,
and places the configuration in each respective logic (see TSFE hook),
where as the Indexer does not know about TSFE or "called from Backend"
anymore, making the indexer just doing its work.

The next iteration will then separate all indexing logic into smaller
chunks again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1121

  1. Benni Mack uploaded patch set 1 04/01/20, 12:08

  2. TYPO3com voted on patch set 1 V -1 04/01/20, 12:19 Completed build in 10m 58s on Wed, 1 Apr, 12:19 PM Test Summary: 51 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2051

  3. Benni Mack uploaded patch set 2 04/01/20, 12:41

  4. TYPO3com voted on patch set 2 V -1 04/01/20, 12:53 Completed build in 11m 36s on Wed, 1 Apr, 12:53 PM Test Summary: 35 of 73536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2052

  5. TYPO3com commented on patch set 2 04/01/20, 17:00 Completed build in 22m 55s on Wed, 1 Apr, 05:00 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2052

  6. TYPO3com commented on patch set 2 04/01/20, 18:01 Completed build in 1h 35m 43s on Wed, 1 Apr, 06:01 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2052

  7. Benni Mack rebased onto patch set 3 04/01/20, 19:09

  8. TYPO3com voted on patch set 3 V -1 04/01/20, 19:25 Completed build in 15m 06s on Wed, 1 Apr, 07:25 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2064

  9. TYPO3com commented on patch set 3 04/02/20, 09:36 Completed build in 14h 41m 53s on Thu, 2 Apr, 09:36 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2064

  10. Benni Mack commented on patch set 4 04/02/20, 10:34

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V -1 04/02/20, 11:05 Completed build in 14m 46s on Thu, 2 Apr, 11:05 AM Test Summary: 72947 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2093

  12. TYPO3com commented on patch set 4 04/02/20, 11:48 Completed build in 1h 12m 46s on Thu, 2 Apr, 11:48 AM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2093

  13. Benni Mack uploaded patch set 5 04/02/20, 12:38

  14. TYPO3com voted on patch set 5 V -1 04/02/20, 12:48 Completed build in 10m 40s on Thu, 2 Apr, 12:48 PM Test Summary: 73248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2095

  15. TYPO3com voted on patch set 5 V +1 04/02/20, 18:36 Completed build in 6h 09m 06s on Thu, 2 Apr, 06:36 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2095

  16. Andreas Kienast voted on patch set 5 CR +1 04/03/20, 08:14

  17. Andreas Kienast voted on patch set 5 V +1 04/03/20, 14:00

  18. Susi Moog voted on patch set 5 V +1 CR +1 04/03/20, 14:00

  19. Benni Mack voted on patch set 5 V +2 CR +2 04/03/20, 14:33

  20. Benni Mack merged patch set 6 04/03/20, 14:33

  21. Frank Nägler voted on patch set 6 V +1 CR +1 04/03/20, 14:37