Review main Merged

64041[BUGFIX] Improve readability of records in workspace module

Uwe Trotzek CR +2 V +2 Normal +46 −16 updated 08/12/20, 18:11

Commit message

If workspace records are present on deeply nested pages or
have long titles the action buttons can not be reached.
A vertical scroll bar will be the result.
The patch uses existing server side crop methods.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Uwe Trotzek uploaded patch set 1 04/01/20, 14:17

  2. Uwe Trotzek updated the commit message in patch set 2 04/01/20, 14:24

  3. TYPO3com voted on patch set 1 V -1 04/01/20, 14:28 Completed build in 11m 23s on Wed, 1 Apr, 02:28 PM Test Summary: 5 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2054

  4. TYPO3com voted on patch set 2 V -1 04/01/20, 14:36 Completed build in 11m 08s on Wed, 1 Apr, 02:36 PM Test Summary: 8 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2055

  5. Christian Kuhn commented on patch set 2 CR -1 08/12/20, 14:36

    working on this. I'll try to crop server side.

    Backend.ts:634 Unresolved

    note this introduces a potential CSS vector.
  6. Christian Kuhn uploaded patch set 3 08/12/20, 14:48

  7. Christian Kuhn updated the commit message in patch set 4 08/12/20, 14:56

  8. TYPO3com voted on patch set 3 V +1 08/12/20, 15:00 Completed build in 12m 05s on Wed, 12 Aug, 03:00 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4596

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 08/12/20, 15:01

  10. TYPO3com voted on patch set 4 V +1 08/12/20, 15:09 Completed build in 13m 10s on Wed, 12 Aug, 03:09 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4597

  11. Anja Leichsenring voted on patch set 4 V +2 CR +2 08/12/20, 18:11

  12. Anja Leichsenring merged patch set 5 08/12/20, 18:11