Review main Abandoned

64043[BUGFIX] Streamline ExceptionHandler API

Benni Mack CR 0 V 0 Easy +19 −11 updated 04/01/20, 19:37

Commit message

The main ExceptionHandlerInterface exposes a constructor
which is very bad practice in PHP. As it serves no purpose,
it can safely be removed.

In addition, the AbstractExceptionHandler now defines
the two missing methods of the interface as abstract in order
to fulfil the Interface properly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 04/01/20, 19:08

  2. TYPO3com voted on patch set 1 V -1 04/01/20, 19:20 Completed build in 11m 47s on Wed, 1 Apr, 07:20 PM Test Summary: 30 of 73223 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2063

  3. Alexander Schnitzler commented on patch set 1 04/01/20, 19:23

    Ok, didn't know we have this issue in 9 as well. So I abandon my patch of this morning? https://review.typo3.org/c/Packages/TYPO3.CMS/+/64036
  4. Alexander Schnitzler commented on patch set 1 04/01/20, 19:28

    AbstractExceptionHandler.php:61 Unresolved

    Why is this necesary? I don't think that abstract classes need to implement all methods of the contract. That's why they are abstract. They should be optional and provide functionality which can be shared while the interface defines how the concrete implementation should behave.
  5. Benni Mack commented on patch set 1 04/01/20, 19:37

    ah, didn't see your change. let's abandon mine then
  6. Benni Mack abandoned the change 04/01/20, 19:37