64044[TASK] Upgrade Documentation: add footer links
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Siepmann +1
-
Verified V +2 Done
- Georg Ringer +2
- Daniel Siepmann +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2436
Show 1011 earlier messages
-
Josef Glatz uploaded patch set 1 04/01/20, 19:13
-
Josef Glatz commented on patch set 1 04/01/20, 19:14
Please see issue https://forge.typo3.org/issues/90923 for better overview and a screenshot of patch set 1 -
Georg Ringer commented on patch set 1 04/01/20, 19:22
Please use regular a tag, external link will be deprecated -
TYPO3com voted on patch set 1 V -1 04/01/20, 19:28 Completed build in 12m 47s on Wed, 1 Apr, 07:28 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2065
-
Josef Glatz uploaded patch set 2 04/02/20, 05:29
-
Josef Glatz commented on patch set 2 04/02/20, 05:29
> Patch Set 1: > > Please use regular a tag, external link will be deprecated DONE -
Andreas Kienast commented on patch set 2 CR -1 04/02/20, 05:33
PanelItem.html:32I don't think so :) -
Josef Glatz uploaded patch set 3 04/02/20, 05:33
-
Andreas Kienast uploaded patch set 4 04/02/20, 05:34
-
Andreas Kienast voted on patch set 4 V +1 CR +1 04/02/20, 05:35
-
Josef Glatz uploaded patch set 5 04/02/20, 05:36
-
Josef Glatz uploaded patch set 6 04/02/20, 05:39
-
Andreas Kienast voted on patch set 6 CR +1 04/02/20, 05:39
-
Andreas Kienast voted on patch set 6 V +1 04/02/20, 05:40
-
TYPO3com voted on patch set 2 V -1 04/02/20, 05:41 Completed build in 11m 57s on Thu, 2 Apr, 05:41 AM Test Summary: 72754 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2071
-
Daniel Siepmann commented on patch set 6 04/02/20, 05:55
Should we also add the link to the extension scanner? That was the first place I tried to find the feature. Or should that be a separate patch, would be ok for me.PanelItem.html:30I see the link at the bottom, maybe due to CSS? Would it make sense to only use an Icon (with title) and add it to the top? Maybe People using the rendered version are unlikely to like the "pre" version we render in backend and want to jump directly to the rendered version. -
TYPO3com voted on patch set 3 V -1 04/02/20, 05:59 Completed build in 23m 42s on Thu, 2 Apr, 05:59 AM Test Summary: 4 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2072
-
Josef Glatz commented on patch set 6 04/02/20, 06:28
> Patch Set 6: > > (1 comment) > > Should we also add the link to the extension scanner? That was the first place I tried to find the feature. Or should that be a separate patch, would be ok for me. Ah I see, good idea. From my perspective, this should be a separate patch. For example there are actually no tags shown. I can take care of it in another patchPanelItem.html:30ReplyThe link is positioned at the end of the pre, exactly. In a first try, I positioned it under the tags, with just the icon. Because icon + text looks crowded to me. Then I thought using meaningful links is better for overall a11y. That was the reason to use a simple link with a label. But yes, I'm also in if we decide only to show the icon without a visible label. Is it good to use the title attribute when taking a11y into account? We can also show the link twice. Or displaying the link to the forge-issue and docs.typo3.org in one place. And one link at the end of the document. Since some docs are really long, it would be a benefit if I can at least open the rendered doc at the end. (At least, that's my workflow when I do TYPO3 upgrades: i try to use the unrendered doc and if it's to complicated to consume for me, I search for the rendered version on google, most time if I'm at the end of a document) At the end: a link anywhere is better than no link. We can use this patch in a first run and can think about bigger improvements.PanelItem.html:32ReplyAck -
TYPO3com voted on patch set 6 V -1 04/02/20, 06:28 Completed build in 34m 24s on Thu, 2 Apr, 06:28 AM Test Summary: 72748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2075
-
TYPO3com voted on patch set 4 V -1 04/02/20, 06:30 Completed build in 53m 46s on Thu, 2 Apr, 06:30 AM Test Summary: 1 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2073
-
TYPO3com voted on patch set 5 V -1 04/02/20, 06:30 Completed build in 43m 43s on Thu, 2 Apr, 06:30 AM Test Summary: 99 of 72909 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2074
-
TYPO3com commented on patch set 5 04/02/20, 06:43 Completed build in 1h 40m 57s on Thu, 2 Apr, 06:43 AM Test Summary: 1 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2074
-
Daniel Siepmann commented on patch set 6 04/02/20, 09:58
PanelItem.html:30ReplySure :) You can ask Michael Telgkamp regarding a11y, he is part of the Accessibility Initiative. -
Josef Glatz commented on patch set 6 04/02/20, 15:19
PanelItem.html:30Reply UnresolvedI asked him. A link with a text is always better instead of just an icon. If we don't show text, we should put the existing text in a screenready-only-css-class (.sr-only) or we can use aria-label. The title tag is only for users with mouse. My proposal to you: 1. let's keep the link at the bottom as it is now. At the bottom it's place enough to show a meaningful link label 2. In a 2nd patch I will come up with a solution at the beginning of the document. Taking existing tags, forge-url and doc-url into account. -
Josef Glatz uploaded patch set 7 04/05/20, 15:33
-
Josef Glatz commented on patch set 7 04/05/20, 15:37
Added screenshots for patchset 7: https://forge.typo3.org/issues/90923#Patch-Set-7-Screenshots The patch focus on the footer of the document. -
TYPO3com voted on patch set 7 V -1 04/05/20, 15:47 Completed build in 13m 21s on Sun, 5 Apr, 03:47 PM Test Summary: 18 of 73396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2194
-
Josef Glatz uploaded patch set 8 04/05/20, 16:02
-
TYPO3com voted on patch set 8 V -1 04/05/20, 16:22 Completed build in 19m 21s on Sun, 5 Apr, 04:22 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2195
-
TYPO3com commented on patch set 8 04/05/20, 18:03 Completed build in 23m 49s on Sun, 5 Apr, 06:03 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2196
-
TYPO3com commented on patch set 8 04/05/20, 18:17 Completed build in 14m 22s on Sun, 5 Apr, 06:17 PM Test Summary: 73047 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2197
-
Josef Glatz uploaded patch set 9 04/05/20, 19:04
-
TYPO3com voted on patch set 9 V +1 04/05/20, 19:17 Completed build in 12m 38s on Sun, 5 Apr, 07:17 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2201
-
Daniel Siepmann voted on patch set 9 V +1 CR +1 04/06/20, 05:55
-
Georg Ringer voted on patch set 9 V +2 CR +2 04/06/20, 06:39
-
Georg Ringer merged patch set 10 04/06/20, 06:39