Review main Merged

64045[TASK] Remove unused code related to config.locale_all

Benni Mack CR +2 V +2 Easy +1 −9 updated 04/02/20, 05:32

Commit message

In TYPO3 v10 locale is set very early in due to the availability of the Site Language,
making the whole set up working properly without having to evaluate
config.locale_all TypoScript.

This code can now safely be removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 04/01/20, 19:30

  2. Benni Mack updated the commit message in patch set 2 04/01/20, 19:37

  3. TYPO3com voted on patch set 1 V +1 04/01/20, 19:42 Completed build in 11m 57s on Wed, 1 Apr, 07:42 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2066

  4. TYPO3com voted on patch set 2 V +1 04/01/20, 19:48 Completed build in 11m 30s on Wed, 1 Apr, 07:48 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2067

  5. Wouter Wolters voted on patch set 2 CR +1 04/01/20, 21:08

  6. Georg Ringer voted on patch set 2 V +1 CR +1 04/01/20, 21:45

  7. Josef Glatz voted on patch set 2 V +1 CR +1 04/02/20, 05:27

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 04/02/20, 05:31

  9. Andreas Kienast merged patch set 3 04/02/20, 05:32