Review main Merged

64047[TASK] Remove bootstrap-slider library

Andreas Kienast CR +2 V +2 Normal +35 −21 updated 04/03/20, 14:59

Commit message

This patch removes the bootstrap-slider library used to render input
sliders. Such elements have been replaced with HTML input fields using
`type="range"` which provides the same base functionality some time ago.

Since using bootstrap-slider with TYPO3 is neither documented nor
propagated, removing this library isn't considered as breaking change.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1

Issues 1

Files 8

Review log 1319

  1. Andreas Kienast uploaded patch set 1 04/02/20, 06:30

  2. TYPO3com voted on patch set 1 V -1 04/02/20, 06:42 Completed build in 12m 17s on Thu, 2 Apr, 06:42 AM Test Summary: 1 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2076

  3. TYPO3com voted on patch set 1 V +1 04/02/20, 06:50 Completed build in 32m 40s on Thu, 2 Apr, 06:50 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2076

  4. Georg Ringer commented on patch set 2 04/02/20, 08:42

    Published edit on patch set 1.
  5. Georg Ringer voted on patch set 2 V +1 CR +1 04/02/20, 08:42

  6. TYPO3com voted on patch set 2 V +1 04/02/20, 08:53 Completed build in 10m 36s on Thu, 2 Apr, 08:53 AM Test Summary: 73051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2077

  7. Benni Mack commented on patch set 2 04/02/20, 09:35

    Important-90897-RemoveBootstrap-slider.rst:13

    I assume you mean type="range"?
  8. Andreas Kienast commented on patch set 2 04/02/20, 09:48

    Important-90897-RemoveBootstrap-slider.rst:13 Reply Unresolved

    ehm, yep...
  9. Andreas Kienast commented on patch set 3 04/02/20, 09:48

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 04/02/20, 10:00 Completed build in 11m 36s on Thu, 2 Apr, 10:00 AM Test Summary: 73051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2084

  11. Oliver Klee voted on patch set 3 CR +1 04/02/20, 10:10

  12. Andreas Kienast updated the commit message in patch set 4 04/03/20, 14:39

  13. Andreas Kienast updated the commit message in patch set 5 04/03/20, 14:39

  14. Oliver Klee voted on patch set 5 CR +1 04/03/20, 14:40

  15. Georg Ringer voted on patch set 5 V +1 CR +1 04/03/20, 14:45

  16. Frank Nägler voted on patch set 5 V +2 CR +2 04/03/20, 14:49

  17. Frank Nägler merged patch set 6 04/03/20, 14:49

  18. TYPO3com voted on patch set 4 V +1 04/03/20, 14:54 Completed build in 14m 57s on Fri, 3 Apr, 02:54 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2128

  19. TYPO3com voted on patch set 5 V +1 04/03/20, 14:59 Completed build in 19m 16s on Fri, 3 Apr, 02:59 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2130