64049[BUGFIX] Re-Implement record_is_used hook for Fluid-based page view
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Claus Due +1
- Oli Bartsch +1
- Kevin Appelt +1
-
Verified V +2 Done
- Georg Ringer +2
- Claus Due +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2026
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 04/02/20, 09:55
-
TYPO3com voted on patch set 1 V +1 04/02/20, 10:07 Completed build in 12m 05s on Thu, 2 Apr, 10:07 AM Test Summary: 73051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2085
-
Georg Ringer voted on patch set 1 V +1 CR +1 04/02/20, 19:07
-
Claus Due commented on patch set 1 04/03/20, 07:43
-
Benni Mack commented on patch set 1 04/03/20, 08:17
ContentFetcher.php:116Replywe can do that, this would still break GridElements and Mask (currently). In addition, we should either keep or remove it in both places (classic page module and fluid-based page module) -
Claus Due commented on patch set 1 CR +1 04/03/20, 08:45
ContentFetcher.php:116Reply Unresolved> we can do that, this would still break GridElements and Mask (currently). Okay, no problem to keep it imo. > In addition, we should either keep or remove it in both places (classic page module and fluid-based page module) We're not quite there yet, unfortunately. So we have to keep it for the time being. -
Claus Due voted on patch set 1 V +1 04/03/20, 09:00
-
Claus Due commented on patch set 1 V 0 CR 0 04/03/20, 10:24
ContentFetcher.php:122UnresolvedI think we can change this to: $used = $rememberer->isRemembered((int)$contentRecord['uid']); The record will be remembered if it was added to a column, so we shouldn't need to check the columns at this point. -
Achim Fritz voted on patch set 1 V +1 CR +1 04/03/20, 13:32
-
Benni Mack commented on patch set 2 04/03/20, 18:46
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 04/03/20, 18:58 Completed build in 11m 38s on Fri, 3 Apr, 06:58 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2137
-
Georg Ringer commented on patch set 2 04/03/20, 19:42
ContentFetcher.php:122Unresolvedso why not using $used = $rememberer->isRemembered((int)$contentRecord['uid'])? -
Benni Mack commented on patch set 3 04/03/20, 20:54
Published edit on patch set 2. -
Claus Due voted on patch set 3 CR +1 04/03/20, 20:57
-
TYPO3com voted on patch set 3 V -1 04/03/20, 21:15 Completed build in 20m 32s on Fri, 3 Apr, 09:15 PM Test Summary: 1 of 73742 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2142
-
TYPO3com voted on patch set 3 V +1 04/03/20, 21:19 Completed build in 45m 50s on Fri, 3 Apr, 09:19 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2142
-
Susi Moog voted on patch set 3 V +1 CR +1 04/04/20, 06:20
-
Claus Due voted on patch set 3 V +1 04/04/20, 09:48
-
Claus Due updated the commit message in patch set 4 04/04/20, 10:02
-
Kevin Appelt voted on patch set 4 CR +1 04/04/20, 10:10
-
TYPO3com voted on patch set 4 V -1 04/04/20, 10:14 Completed build in 12m 04s on Sat, 4 Apr, 10:14 AM Test Summary: 72968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2155
-
TYPO3com voted on patch set 4 V +1 04/04/20, 10:23 Completed build in 33m 50s on Sat, 4 Apr, 10:23 AM Test Summary: 73288 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2155
-
Oli Bartsch commented on patch set 4 V +1 CR +1 04/04/20, 10:34
Great to have this back! -
Claus Due commented on patch set 4 V +1 CR +1 04/04/20, 11:32
Repeating +1/+1 since last change was only a commit message update. -
Georg Ringer voted on patch set 4 V +2 CR +2 04/04/20, 11:35
-
Georg Ringer merged patch set 5 04/04/20, 11:35
ContentFetcher.php:116