Review main Merged

64049[BUGFIX] Re-Implement record_is_used hook for Fluid-based page view

Benni Mack CR +2 V +2 Easy +15 −1 updated 04/04/20, 11:35

Commit message

The hook to determine if child records are used is re-implemented.
This makes the fluid based page module behave like the legacy
PageLayoutView when determining if a record was used, allowing
third party extensions to override the core's "is used?" decision.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Claus Due +1
    • Oli Bartsch +1
    • Kevin Appelt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Claus Due +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2026

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 04/02/20, 09:55

  1. TYPO3com voted on patch set 1 V +1 04/02/20, 10:07 Completed build in 12m 05s on Thu, 2 Apr, 10:07 AM Test Summary: 73051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2085

  2. Georg Ringer voted on patch set 1 V +1 CR +1 04/02/20, 19:07

  3. Claus Due commented on patch set 1 04/03/20, 07:43

    ContentFetcher.php:116

    Since there is likely to be very few instances of this hook being used out in the wild, we could take this opportunity to remove the passing of $pageLayoutView. It's not a huge thing though, since this method only gets called once per backend page view.
  4. Benni Mack commented on patch set 1 04/03/20, 08:17

    ContentFetcher.php:116 Reply

    we can do that, this would still break GridElements and Mask (currently). In addition, we should either keep or remove it in both places (classic page module and fluid-based page module)
  5. Claus Due commented on patch set 1 CR +1 04/03/20, 08:45

    ContentFetcher.php:116 Reply Unresolved

    > we can do that, this would still break GridElements and Mask (currently). Okay, no problem to keep it imo. > In addition, we should either keep or remove it in both places (classic page module and fluid-based page module) We're not quite there yet, unfortunately. So we have to keep it for the time being.
  6. Claus Due voted on patch set 1 V +1 04/03/20, 09:00

  7. Claus Due commented on patch set 1 V 0 CR 0 04/03/20, 10:24

    ContentFetcher.php:122 Unresolved

    I think we can change this to: $used = $rememberer->isRemembered((int)$contentRecord['uid']); The record will be remembered if it was added to a column, so we shouldn't need to check the columns at this point.
  8. Achim Fritz voted on patch set 1 V +1 CR +1 04/03/20, 13:32

  9. Benni Mack commented on patch set 2 04/03/20, 18:46

    Published edit on patch set 1.
  10. TYPO3com voted on patch set 2 V +1 04/03/20, 18:58 Completed build in 11m 38s on Fri, 3 Apr, 06:58 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2137

  11. Georg Ringer commented on patch set 2 04/03/20, 19:42

    ContentFetcher.php:122 Unresolved

    so why not using $used = $rememberer->isRemembered((int)$contentRecord['uid'])?
  12. Benni Mack commented on patch set 3 04/03/20, 20:54

    Published edit on patch set 2.
  13. Claus Due voted on patch set 3 CR +1 04/03/20, 20:57

  14. TYPO3com voted on patch set 3 V -1 04/03/20, 21:15 Completed build in 20m 32s on Fri, 3 Apr, 09:15 PM Test Summary: 1 of 73742 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2142

  15. TYPO3com voted on patch set 3 V +1 04/03/20, 21:19 Completed build in 45m 50s on Fri, 3 Apr, 09:19 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2142

  16. Susi Moog voted on patch set 3 V +1 CR +1 04/04/20, 06:20

  17. Claus Due voted on patch set 3 V +1 04/04/20, 09:48

  18. Claus Due updated the commit message in patch set 4 04/04/20, 10:02

  19. Kevin Appelt voted on patch set 4 CR +1 04/04/20, 10:10

  20. TYPO3com voted on patch set 4 V -1 04/04/20, 10:14 Completed build in 12m 04s on Sat, 4 Apr, 10:14 AM Test Summary: 72968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2155

  21. TYPO3com voted on patch set 4 V +1 04/04/20, 10:23 Completed build in 33m 50s on Sat, 4 Apr, 10:23 AM Test Summary: 73288 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2155

  22. Oli Bartsch commented on patch set 4 V +1 CR +1 04/04/20, 10:34

    Great to have this back!
  23. Claus Due commented on patch set 4 V +1 CR +1 04/04/20, 11:32

    Repeating +1/+1 since last change was only a commit message update.
  24. Georg Ringer voted on patch set 4 V +2 CR +2 04/04/20, 11:35

  25. Georg Ringer merged patch set 5 04/04/20, 11:35