Review main Merged

64050[BUGFIX] Correctly initialize SiteConfiguration in functional tests

Oliver Hader CR +2 V +2 Easy +6 −4 updated 04/02/20, 11:01

Commit message

SiteConfiguration requires configuration path to be defined. Since
this class is a singleton it might happen that SiteFinder created
an instance already.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Oliver Hader uploaded patch set 1 04/02/20, 10:31

  2. Oliver Hader commented on patch set 1 04/02/20, 10:32

  3. TYPO3com voted on patch set 1 V +1 04/02/20, 10:56 Completed build in 23m 26s on Thu, 2 Apr, 10:56 AM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2092

  4. Oliver Hader voted on patch set 1 V +2 CR +2 04/02/20, 11:01

  5. Oliver Hader merged patch set 2 04/02/20, 11:01