Review main Abandoned

64052WIP: [FEATURE] add option to disable version highlighting in page tree

Uwe Trotzek CR 0 V 0 Easy +15 −1 updated 11/10/21, 11:54

Commit message

In bigger instances the processing of versions for the whole page tree
is a performance killer. This patch adds an option to let the user
decide if the highlighting of versions in the page tree should be
active or not.

TODO: make this value configurable via workspace configuration

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Uwe Trotzek uploaded patch set 1 04/02/20, 14:25

  2. TYPO3com voted on patch set 1 V +1 04/02/20, 14:37 Completed build in 11m 49s on Thu, 2 Apr, 02:37 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2098

  3. Danilo Caccialanza commented on patch set 1 V +1 CR +1 07/01/20, 14:11

    I confirm that there is a performance problem. The patch actually improves performance a lot. In my opinion you can release this patch, but it should not be the final solution of the problem because the color of the versioned page is important to be able to have it with good performance.
  4. Danilo Caccialanza wrote 07/23/20, 09:03

    Removed Code-Review+1 by Danilo Caccialanza <supercaccia@bluewin.ch>
  5. Christian Kuhn commented on patch set 1 07/28/20, 12:55

    Patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086 which has been released with todays releases in v9, v10 and master mitigates the issue a lot since the page tree is fetched in much smaller chunks now. The similar issue https://forge.typo3.org/issues/91728 has already been closed due to that patch. If nobody objects, I'd tend to abandon this approach soon.
  6. Danilo Caccialanza commented on patch set 1 V -1 07/28/20, 13:05

    > Patch Set 1: > > Patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086 which has been released with todays releases in v9, v10 and master mitigates the issue a lot since the page tree is fetched in much smaller chunks now. > The similar issue https://forge.typo3.org/issues/91728 has already been closed due to that patch. > If nobody objects, I'd tend to abandon this approach soon. I also think that after relays 10.4.6 and 9.5.20 this approach can be abandoned.
  7. Benni Mack abandoned the change 11/10/21, 11:54

    abandoning this change now