Review main Merged

64055[TASK] Deprecate various hooks in ContentObjectRenderer

Benni Mack CR +2 V +2 Normal +83 −0 updated 04/04/20, 06:26

Commit message

The following hooks within ContentObjectRenderer have been marked as deprecated:

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClass']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClassDefault']

Both concepts have been superseded in TYPO3 v6 with custom cObjects via

$GLOBALS['TYPO3_CONF_VARS']['FE']['ContentObjects']

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['extLinkATagParamsHandler']
* cObj->extLinkATagParams() is now also marked as internal, as it serves no purpose anymore once the hook gets removed.

In addition
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['typolinkLinkHandler']
is deprecated since the initial addition of LinkHandler APIs in TYPO3 v8.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 812

  1. Benni Mack uploaded patch set 1 04/02/20, 20:45

  2. TYPO3com voted on patch set 1 V +1 04/02/20, 20:56 Completed build in 11m 07s on Thu, 2 Apr, 08:56 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2107

  3. Benni Mack uploaded patch set 2 04/03/20, 06:53

  4. TYPO3com voted on patch set 2 V +1 04/03/20, 07:09 Completed build in 16m 24s on Fri, 3 Apr, 07:09 AM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2116

  5. Benni Mack commented on patch set 2 04/03/20, 07:47

    ContentObjectRenderer.php:743 Unresolved

    looks like we should also deprecate the interface then Iguess
  6. Benni Mack uploaded patch set 3 04/03/20, 08:25

  7. TYPO3com voted on patch set 3 V +1 04/03/20, 08:53 Completed build in 21m 40s on Fri, 3 Apr, 08:53 AM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2119

  8. Georg Ringer commented on patch set 4 04/03/20, 19:38

    Published edit on patch set 3.
  9. Georg Ringer voted on patch set 4 V +1 CR +1 04/03/20, 19:38

  10. TYPO3com voted on patch set 4 V +1 04/03/20, 19:54 Completed build in 15m 14s on Fri, 3 Apr, 07:54 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2139

  11. Susi Moog voted on patch set 4 V +2 CR +2 04/04/20, 06:26

  12. Susi Moog merged patch set 5 04/04/20, 06:26