Review main Merged

64056[TASK] Deprecate logic in LanguageService

Benni Mack CR +2 V +2 Normal +97 −5 updated 04/08/20, 20:11

Commit message

The master $GLOBALS[LANG] object should have a more
streamlined API and some methods and public properties
are now deprecated, in order to make this API much more
stateless.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 712

  1. Benni Mack uploaded patch set 1 04/02/20, 21:22

  2. Benni Mack uploaded patch set 2 04/02/20, 21:25

  3. TYPO3com voted on patch set 1 V -1 04/02/20, 21:51 Completed build in 26m 07s on Thu, 2 Apr, 09:51 PM Test Summary: 17 of 73743 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2111

  4. TYPO3com voted on patch set 2 V -1 04/02/20, 21:51 Completed build in 26m 08s on Thu, 2 Apr, 09:51 PM Test Summary: 7 of 72589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2112

  5. TYPO3com voted on patch set 2 V +1 04/03/20, 06:40 Completed build in 9h 40m 45s on Fri, 3 Apr, 06:40 AM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2112

  6. Benni Mack updated the commit message in patch set 3 04/06/20, 15:53

  7. Benni Mack uploaded patch set 4 04/06/20, 16:05

  8. TYPO3com voted on patch set 3 V +1 04/06/20, 16:08 Completed build in 14m 49s on Mon, 6 Apr, 04:08 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2235

  9. TYPO3com voted on patch set 4 V +1 04/06/20, 16:18 Completed build in 12m 36s on Mon, 6 Apr, 04:18 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2237

  10. Georg Ringer voted on patch set 4 V +1 CR +1 04/08/20, 19:55

  11. Daniel Goerz voted on patch set 4 V +2 CR +2 04/08/20, 20:11

  12. Daniel Goerz merged patch set 5 04/08/20, 20:11