Review main Merged

64060[BUGFIX] Do not promote deprecated TS condition syntax in changelog

Tymoteusz Motylewski CR +2 V +2 Easy +5 −4 updated 04/14/20, 11:24

Commit message

The old TS Conditions syntax with two blocks combined with && is deprecated
so it should not be used as an example in the changelog.

It was deprecated in:
https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5/Deprecation-86068-OldConditionSyntax.html

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Tymoteusz Motylewski uploaded patch set 1 04/03/20, 12:38

  2. TYPO3com voted on patch set 1 V +1 04/03/20, 12:50 Completed build in 11m 54s on Fri, 3 Apr, 12:50 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2123

  3. Tymoteusz Motylewski updated the commit message in patch set 2 04/14/20, 05:43

  4. Georg Ringer voted on patch set 2 V +1 CR +1 04/14/20, 06:04

  5. Josef Glatz voted on patch set 2 V +1 CR +1 04/14/20, 06:06

  6. TYPO3com voted on patch set 2 V +1 04/14/20, 06:13 Completed build in 20m 59s on Tue, 14 Apr, 06:13 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2467

  7. Björn Jacob commented on patch set 2 CR -1 04/14/20, 06:31

    Feature-85829-ImplementSymfonyExpressionLanguageForTypoScriptConditions.rst:37

    We need third person here which would be "matches". Sry guys :)
  8. Björn Jacob commented on patch set 3 04/14/20, 06:31

    Published edit on patch set 2.
  9. Björn Jacob commented on patch set 3 V +1 CR +1 04/14/20, 06:32

    Feature-85829-ImplementSymfonyExpressionLanguageForTypoScriptConditions.rst:37 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 04/14/20, 06:43 Completed build in 11m 44s on Tue, 14 Apr, 06:43 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2471

  11. Josef Glatz commented on patch set 3 V +1 CR +1 04/14/20, 06:44

    Thx bro! this was the missing yellow from the egg
  12. Björn Jacob commented on patch set 3 04/14/20, 06:45

    Thx mate! Made my day :)
  13. Oli Bartsch voted on patch set 3 V +1 CR +1 04/14/20, 08:48

  14. Benni Mack voted on patch set 3 V +2 CR +2 04/14/20, 11:24

  15. Benni Mack merged patch set 4 04/14/20, 11:24