Review main Merged

64062[BUGFIX] correctly resolve saved mm relations in TCA

Tobi Kretschmann CR +2 V +2 Easy +20 −8 updated 04/11/20, 20:40

Commit message

Using mm tables, the value that is stored in the database does not represent the
uid of the selected item. Much rather it is the amount of selected items.
If three items are selected the value within the database field is "3".
Whereas using multiple select without mm table, it is stored as a
comma-separated list of uids.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • Sebastian Hofer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • Sebastian Hofer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Tobi Kretschmann uploaded patch set 1 04/03/20, 14:39

  2. TYPO3com voted on patch set 1 V -1 04/03/20, 14:40 Completed build in 35s on Fri, 3 Apr, 02:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2129

  3. Tobi Kretschmann uploaded patch set 2 04/03/20, 14:46

  4. TYPO3com voted on patch set 2 V +1 04/03/20, 15:04 Completed build in 14m 23s on Fri, 3 Apr, 03:04 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2131

  5. Oliver Klee commented on patch set 2 04/03/20, 16:00

    TcaSelectItems.php:82 Unresolved

    e -> a
  6. Tobi Kretschmann commented on patch set 3 04/03/20, 16:11

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V +1 04/03/20, 16:23 Completed build in 12m 27s on Fri, 3 Apr, 04:23 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2136

  8. Benni Mack commented on patch set 3 V -1 04/03/20, 20:48

    Still does not work for me :( * foreign_table * MM * no static values editing an existing item always adds another item to edit when opening form engine (if I have four items in there, it always adds the uid=4 as well)
  9. Benni Mack voted on patch set 3 V +1 CR +1 04/08/20, 21:30

  10. Jörg Bösche voted on patch set 3 V +1 CR +1 04/09/20, 12:21

  11. Georg Ringer commented on patch set 3 04/09/20, 12:59

  12. Sebastian Hofer voted on patch set 3 CR +1 04/09/20, 13:12

  13. Sebastian Hofer voted on patch set 3 V +1 04/09/20, 13:32

  14. Benni Mack voted on patch set 3 V +2 CR +2 04/11/20, 20:40

  15. Benni Mack merged patch set 4 04/11/20, 20:40