Review main Abandoned

64063[WIP][BUGFIX] Add move existing record to pid in process_datamap()

Stefan Bürk CR 0 V 0 Normal +85 −0 updated 08/14/21, 14:19

Commit message

Move record in datamap processing for existing record, if pid
to is provided as pid field to behave in the same way as it was
a new record. In the same step, further fields
are updated as well.

If provided pid is a NEW... id, it is substituted before moving
the record.

The behaviour before was to silently ignore the pid field,
without substituting a NEW... id value to a real id.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 813

  1. Stefan Bürk uploaded patch set 1 04/03/20, 19:47

  2. TYPO3com voted on patch set 1 V -1 04/03/20, 20:05 Completed build in 16m 12s on Fri, 3 Apr, 08:05 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2140

  3. Stefan Bürk rebased onto patch set 2 04/03/20, 21:51

  4. TYPO3com voted on patch set 2 V +1 04/03/20, 22:09 Completed build in 14m 25s on Fri, 3 Apr, 10:09 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2145

  5. TYPO3com commented on patch set 2 04/03/20, 22:21 Completed build in 12m 03s on Fri, 3 Apr, 10:21 PM Test Summary: 73256 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2146

  6. Stefan Bürk uploaded patch set 3 04/04/20, 12:32

  7. Stefan Bürk rebased onto patch set 4 04/04/20, 12:34

  8. TYPO3com voted on patch set 3 V +1 04/04/20, 12:45 Completed build in 12m 43s on Sat, 4 Apr, 12:45 PM Test Summary: 73291 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2158

  9. TYPO3com voted on patch set 4 V +1 04/04/20, 12:51 Completed build in 15m 06s on Sat, 4 Apr, 12:51 PM Test Summary: 73291 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2159

  10. Jonas Eberle voted on patch set 4 V +1 04/09/20, 13:03

  11. Jonas Eberle commented on patch set 4 04/09/20, 13:10

    DataHandler.php:990 Unresolved

    Maybe it makes sense to move the duplicated code from 918ff into a function.
  12. Jonas Eberle voted on patch set 4 CR +1 04/09/20, 13:10

  13. Stefan Bürk abandoned the change 08/14/21, 14:19

    Will recheck / create new at some point