Review main Merged

64064[BUGFIX] Convert page UID to proper link syntax in LinkBrowser

Markus Klein CR +2 V +2 Easy +8 −2 updated 04/06/20, 05:42

Commit message

If the pageIdSelector feature is enabled for the RTE
the entered page UID needs to be formatted with correct
link syntax.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1924

  1. Markus Klein uploaded patch set 1 04/03/20, 20:40

  2. TYPO3com voted on patch set 1 V -1 04/03/20, 20:54 Completed build in 13m 24s on Fri, 3 Apr, 08:54 PM Test Summary: 73247 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2141

  3. Jonas Eberle uploaded patch set 2 04/03/20, 21:44

  4. TYPO3com voted on patch set 2 V +1 04/03/20, 21:58 Completed build in 13m 57s on Fri, 3 Apr, 09:58 PM Test Summary: 73258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2143

  5. Georg Ringer commented on patch set 2 CR -1 04/03/20, 23:21

    no 8-7, thx
  6. Markus Klein abandoned the change 04/04/20, 17:49

    Patch only created to be available for cherry-pick for those who need it.
  7. Markus Klein restored the change 04/04/20, 17:51

  8. Markus Klein commented on patch set 2 04/04/20, 17:52

    > Patch Set 2: Code-Review-1 > > no 8-7, thx I would like to create the backport for v8 here too and to abandon that one, so people can cherry-pick it, if they still need it (or if ELTS wants it). Please lets keep the v8 in the commit message, so we document that this was broken there too.
  9. Georg Ringer voted on patch set 2 CR 0 04/05/20, 18:29

  10. Josef Glatz commented on patch set 2 04/05/20, 18:41

    > Patch Set 2: > > > Patch Set 2: Code-Review-1 > > > > no 8-7, thx > > I would like to create the backport for v8 here too and to abandon that one, so people can cherry-pick it, if they still need it (or if ELTS wants it). > Please lets keep the v8 in the commit message, so we document that this was broken there too. Do we have to add a new different patch instead of working on this, since you want to add a not submitted backport for composer patches for ELTS 8.7 users?
  11. Josef Glatz updated the commit message in patch set 3 04/05/20, 19:14

  12. Josef Glatz commented on patch set 3 V +1 CR +1 04/05/20, 19:17

  13. TYPO3com voted on patch set 3 V +1 04/05/20, 19:26 Completed build in 12m 20s on Sun, 5 Apr, 07:26 PM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2202

  14. Jonas Eberle wrote 04/05/20, 19:27

    Removed reviewer Jonas Eberle.
  15. Josef Glatz commented on patch set 3 04/05/20, 20:17

  16. Andreas Kienast uploaded patch set 4 04/06/20, 04:56

  17. Andreas Kienast voted on patch set 4 V +1 CR +1 04/06/20, 04:56

  18. Andreas Kienast uploaded patch set 5 04/06/20, 04:59

  19. Andreas Kienast voted on patch set 5 V +1 CR +1 04/06/20, 04:59

  20. Josef Glatz commented on patch set 5 V +1 CR +1 04/06/20, 05:05

    still works
  21. TYPO3com voted on patch set 4 V +1 04/06/20, 05:32 Completed build in 26m 39s on Mon, 6 Apr, 05:32 AM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2210

  22. TYPO3com voted on patch set 5 V +1 04/06/20, 05:37 Completed build in 32m 21s on Mon, 6 Apr, 05:37 AM Test Summary: 73366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2211

  23. Georg Ringer voted on patch set 5 V +2 CR +2 04/06/20, 05:42

  24. Georg Ringer merged patch set 6 04/06/20, 05:42