Review main Merged

64065[BUGFIX] Allow pageIdSelector again in non-RTE link browser

Markus Klein CR +2 V +2 Easy +12 −1 updated 04/06/20, 04:41

Commit message

TCEMAIN.linkHandler.page.configuration.pageIdSelector.enabled = 1
This configuration is adhered again and the pageIdSelector shows up.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Markus Klein uploaded patch set 1 04/03/20, 21:51

  2. TYPO3com voted on patch set 1 V -1 04/03/20, 22:04 Completed build in 12m 57s on Fri, 3 Apr, 10:04 PM Test Summary: 72947 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2144

  3. TYPO3com commented on patch set 1 04/04/20, 22:16 Completed build in 12m 44s on Sat, 4 Apr, 10:16 PM Test Summary: 73023 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2182

  4. Andreas Kienast voted on patch set 1 CR +1 04/05/20, 05:32

  5. TYPO3com voted on patch set 1 V +1 04/05/20, 05:37 Completed build in 7h 46m 17s on Sun, 5 Apr, 05:37 AM Test Summary: 73336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2182

  6. Josef Glatz commented on patch set 1 04/05/20, 17:13

    How can I test/reproduce this patch with ext:news? I've tried the following PageTSConfig but I can't see any difference before/after?! (UserTSConfig doesn't work also) > TCEMAIN { linkHandler { tx_news { handler = TYPO3\CMS\Recordlist\LinkHandler\RecordLinkHandler label = TEST LinkHandler ext:news configuration { pageIdSelector.enabled = 1 table = tx_news_domain_model_news hidePageTree = 0 } scanAfter = page } } }
  7. Josef Glatz commented on patch set 1 04/05/20, 17:17

  8. Josef Glatz voted on patch set 1 V -1 04/05/20, 17:46

  9. Markus Klein commented on patch set 1 04/05/20, 18:06

    > Patch Set 1: > > How can I test/reproduce this patch with ext:news? I've tried the following PageTSConfig but I can't see any difference before/after?! (UserTSConfig doesn't work also) > > > TCEMAIN { > linkHandler { > tx_news { > handler = TYPO3\CMS\Recordlist\LinkHandler\RecordLinkHandler > label = TEST LinkHandler ext:news > configuration { > pageIdSelector.enabled = 1 > table = tx_news_domain_model_news > hidePageTree = 0 > } > scanAfter = page > } > } > } This ONLY works with the page-handler not with anything else! This feature is only about selecting the target page by entering the UID in an input field instead of selecting it from a potentially large page tree.
  10. Markus Klein commented on patch set 1 04/05/20, 18:07

    > Patch Set 1: > > > Patch Set 1: > > > > How can I test/reproduce this patch with ext:news? I've tried the following PageTSConfig but I can't see any difference before/after?! (UserTSConfig doesn't work also) > > > > > TCEMAIN { > > linkHandler { > > tx_news { > > handler = TYPO3\CMS\Recordlist\LinkHandler\RecordLinkHandler > > label = TEST LinkHandler ext:news > > configuration { > > pageIdSelector.enabled = 1 > > table = tx_news_domain_model_news > > hidePageTree = 0 > > } > > scanAfter = page > > } > > } > > } > > This ONLY works with the page-handler not with anything else! > This feature is only about selecting the target page by entering the UID in an input field instead of selecting it from a potentially large page tree. See also screenshot in #88656
  11. Josef Glatz commented on patch set 1 04/05/20, 18:16

    Ah, OK. So yes, the new input field is shown. Would it be better to adopt the patch, so that not only the uid (e.g. "6") is set instead of the full t3 url (e.g. "t3://page?uid=6")?
  12. Markus Klein commented on patch set 1 04/05/20, 18:27

    > Patch Set 1: > > Ah, OK. So yes, the new input field is shown. Would it be better to adopt the patch, so that not only the uid (e.g. "6") is set instead of the full t3 url (e.g. "t3://page?uid=6")? Nice catch, but take a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64064 ;-)
  13. Josef Glatz voted on patch set 1 V +1 CR +1 04/05/20, 18:32

  14. Josef Glatz commented on patch set 1 04/05/20, 18:33

    > Patch Set 1: > > > Patch Set 1: > > > > Ah, OK. So yes, the new input field is shown. Would it be better to adopt the patch, so that not only the uid (e.g. "6") is set instead of the full t3 url (e.g. "t3://page?uid=6")? > > Nice catch, but take a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64064 > ;-) Ah I see ツ
  15. Josef Glatz commented on patch set 1 04/05/20, 20:16

  16. Andreas Kienast voted on patch set 1 V +2 CR +2 04/06/20, 04:41

  17. Andreas Kienast merged patch set 2 04/06/20, 04:41