Review main Merged

64066[TASK] Move ExceptionHandler tests into real class instances

Anja Leichsenring CR +2 V +2 Normal +115 −69 updated 04/05/20, 06:37

Commit message

The accessibleMockForAbstractClasses is a discouraged concept
anyways, and in this case the constructor definition in the
interface caused a test failure.
Moving the tests to concrete classes solves the failure and
also gets rid of the abstract class mock.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1826

Show 1 earlier messages
  1. Anja Leichsenring uploaded patch set 1 04/04/20, 08:13

  1. TYPO3com voted on patch set 1 V -1 04/04/20, 08:14 Completed build in 25s on Sat, 4 Apr, 08:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2148

  2. Anja Leichsenring uploaded patch set 2 04/04/20, 08:15

  3. Anja Leichsenring uploaded patch set 3 04/04/20, 08:17

  4. TYPO3com voted on patch set 2 V -1 04/04/20, 08:27 Completed build in 12m 03s on Sat, 4 Apr, 08:27 AM Test Summary: 73317 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2149

  5. TYPO3com voted on patch set 3 V -1 04/04/20, 08:33 Completed build in 14m 49s on Sat, 4 Apr, 08:33 AM Test Summary: 73318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2150

  6. Anja Leichsenring uploaded patch set 4 04/04/20, 08:58

  7. TYPO3com voted on patch set 4 V +1 04/04/20, 09:10 Completed build in 11m 52s on Sat, 4 Apr, 09:10 AM Test Summary: 73317 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2152

  8. Oliver Klee commented on patch set 5 04/04/20, 09:43

    Published edit on patch set 4.
  9. TYPO3com voted on patch set 5 V +1 04/04/20, 09:55 Completed build in 11m 58s on Sat, 4 Apr, 09:55 AM Test Summary: 73318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2154

  10. Georg Ringer voted on patch set 5 V +1 CR +1 04/04/20, 11:36

  11. Andreas Kienast updated the commit message in patch set 6 04/04/20, 13:48

  12. Andreas Kienast voted on patch set 6 V +1 CR +1 04/04/20, 13:50

  13. TYPO3com voted on patch set 6 V +1 04/04/20, 14:04 Completed build in 15m 15s on Sat, 4 Apr, 02:04 PM Test Summary: 73318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2164

  14. Alexander Schnitzler commented on patch set 6 04/04/20, 14:57

    ProductionExceptionHandlerTest.php:54

    What is this change for?
  15. Anja Leichsenring commented on patch set 6 04/04/20, 15:01

    ProductionExceptionHandlerTest.php:54 Reply

    we must only use exception codes once. I copied stuff around, and then of course the check failed. So I made them unique again.
  16. Alexander Schnitzler commented on patch set 6 04/04/20, 15:02

    ProductionExceptionHandlerTest.php:54 Reply

    Yes, but can't we adjust the exception code in the copied code to avoid this change?
  17. Anja Leichsenring commented on patch set 6 04/04/20, 15:09

    ProductionExceptionHandlerTest.php:54 Reply

    it does not matter. The codes serve no purpose but to create the exception.
  18. Alexander Schnitzler commented on patch set 6 04/04/20, 15:12

    ProductionExceptionHandlerTest.php:54 Reply

    I understand. It's just that this change isn't necessary if we change the duplicate code in the code which is copied around anyway. Looking at this patch in 6 months I will ask myself again why this code has been changed with this patch. I won't vote the patch down however. Just think that we can avoid this change.
  19. Anja Leichsenring commented on patch set 7 04/04/20, 15:13

    Published edit on patch set 6.
  20. Alexander Schnitzler commented on patch set 7 04/04/20, 15:14

    ProductionExceptionHandlerTest.php:54 Reply

    Done
  21. Alexander Schnitzler voted on patch set 7 V +1 CR +1 04/04/20, 15:15

  22. TYPO3com voted on patch set 7 V -1 04/04/20, 15:25 Completed build in 12m 23s on Sat, 4 Apr, 03:25 PM Test Summary: 1 of 73850 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2171

  23. TYPO3com voted on patch set 7 V +1 04/04/20, 15:35 Completed build in 34m 24s on Sat, 4 Apr, 03:35 PM Test Summary: 73365 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2171

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 04/05/20, 06:37

  25. Andreas Kienast merged patch set 8 04/05/20, 06:37